It is not necessary to check if a '-' is in lusername., Checking if

lusername starts with a '-' is enough. Otherwise, no users with a '-'
in there name can use rlogin.

1 files changed, 1 insertions, 1 deletions

diff --git a/libexec/rlogind/rlogind.c b/libexec/rlogind/rlogind.c
index f7198ea..5de2a05 100644
--- a/libexec/rlogind/rlogind.c
+++ b/libexec/rlogind/rlogind.c
@@ -302,7 +302,7 @@ doit(f, fromp)
 		if (f > 2)	/* f should always be 0, but... */
 			(void) close(f);
 		setup_term(0);
-		if (strchr(lusername, '-')) {
+		 if (*lusername=='-')) {
 			syslog(LOG_ERR, "tried to pass user \"%s\" to login",
 			       lusername);
 			fatal(STDERR_FILENO, "invalid user", 0);