diff options
| author | ed <ed@FreeBSD.org> | 2008-11-13 19:05:27 +0000 |
|---|---|---|
| committer | ed <ed@FreeBSD.org> | 2008-11-13 19:05:27 +0000 |
| commit | c737fde5da8ad82be2a77a725aa2efdea4213788 (patch) | |
| tree | 9bb27ba397c1269eb811cb12755d0f59d1c0d053 /libexec/telnetd | |
| parent | 4ee5cbf821c9553c41dfee8833555d7d9515f2e6 (diff) | |
| download | FreeBSD-src-c737fde5da8ad82be2a77a725aa2efdea4213788.zip FreeBSD-src-c737fde5da8ad82be2a77a725aa2efdea4213788.tar.gz | |
Convert telnetd(8) to use posix_openpt(2).
Some time ago I got some reports MPSAFE TTY broke telnetd(8). Even
though it turned out to be a different problem within the TTY code, I
spotted a small issue with telnetd(8). Instead of allocating PTY's using
openpty(3) or posix_openpt(2), it used its own PTY allocation routine.
This means that telnetd(8) still uses /dev/ptyXX-style devices.
I've also increased the size of line[]. Even though 16 should be enough,
we already use 13 bytes ("/dev/pts/999", including '\0'). 32 bytes gives
us a little more freedom.
Also enable -DSTREAMSPTY. Otherwise telnetd(8) strips the PTY's pathname
to the latest slash instead of just removing "/dev/" (e.g. /dev/pts/0 ->
0, instead of pts/0).
Reviewed by: rink
Diffstat (limited to 'libexec/telnetd')
| -rw-r--r-- | libexec/telnetd/Makefile | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/libexec/telnetd/Makefile b/libexec/telnetd/Makefile index 3ad8a4e..dcc3398 100644 --- a/libexec/telnetd/Makefile +++ b/libexec/telnetd/Makefile @@ -17,7 +17,8 @@ SRCS= global.c slc.c state.c sys_term.c telnetd.c \ WARNS?= 2 WFORMAT?= 0 -CFLAGS+= -DLINEMODE -DUSE_TERMIO -DDIAGNOSTICS -DOLD_ENVIRON -DENV_HACK +CFLAGS+= -DLINEMODE -DUSE_TERMIO -DDIAGNOSTICS -DOLD_ENVIRON \ + -DENV_HACK -DSTREAMSPTY .if ${MK_INET6_SUPPORT} != "no" CFLAGS+= -DINET6 |
