summaryrefslogtreecommitdiffstats
path: root/libexec/fingerd
diff options
context:
space:
mode:
authorbrian <brian@FreeBSD.org>1999-04-07 06:00:22 +0000
committerbrian <brian@FreeBSD.org>1999-04-07 06:00:22 +0000
commit61dd45edb4d8837efb0d62afc6b3286e81a61dc3 (patch)
tree1e54f2615f0839a6c0015566b62063be84c804e9 /libexec/fingerd
parent365b0a04ef944d2054ba36699022f7245a5eaa97 (diff)
downloadFreeBSD-src-61dd45edb4d8837efb0d62afc6b3286e81a61dc3.zip
FreeBSD-src-61dd45edb4d8837efb0d62afc6b3286e81a61dc3.tar.gz
Fix the size of rhost, don't forget to NUL terminate
it and use brackets for sizeof. Requested by: bde
Diffstat (limited to 'libexec/fingerd')
-rw-r--r--libexec/fingerd/fingerd.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/libexec/fingerd/fingerd.c b/libexec/fingerd/fingerd.c
index 088077c..d14e278 100644
--- a/libexec/fingerd/fingerd.c
+++ b/libexec/fingerd/fingerd.c
@@ -42,7 +42,7 @@ static const char copyright[] =
static char sccsid[] = "@(#)fingerd.c 8.1 (Berkeley) 6/4/93";
#endif
static const char rcsid[] =
- "$Id: fingerd.c,v 1.11 1998/05/15 03:23:28 jb Exp $";
+ "$Id: fingerd.c,v 1.12 1999/04/06 23:05:56 brian Exp $";
#endif /* not lint */
#include <sys/param.h>
@@ -74,7 +74,7 @@ main(argc, argv)
int p[2], logging, secure, sval;
#define ENTRIES 50
char **ap, *av[ENTRIES + 1], **comp, line[1024], *prog;
- char rhost[MAXHOSTNAMELEN + 1];
+ char rhost[MAXHOSTNAMELEN];
prog = _PATH_FINGER;
logging = secure = 0;
@@ -131,6 +131,7 @@ main(argc, argv)
if (getpeername(0, (struct sockaddr *)&sin, &sval) < 0)
logerr("getpeername: %s", strerror(errno));
realhostname(rhost, sizeof rhost - 1, &sin.sin_addr);
+ rhost[sizeof(rhost) - 1] = '\0';
syslog(LOG_NOTICE, "query from %s: `%s'", rhost, t);
}
OpenPOWER on IntegriCloud