summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authortruckman <truckman@FreeBSD.org>2016-05-23 05:14:26 +0000
committertruckman <truckman@FreeBSD.org>2016-05-23 05:14:26 +0000
commiteb959580b55e142236682a8a38adf602bbe3aa77 (patch)
tree1d2c59f57030bd5e00ec52c56ba110c1737a97d8 /lib
parent60eb189f712d30131dea862031451ef39f49124f (diff)
downloadFreeBSD-src-eb959580b55e142236682a8a38adf602bbe3aa77.zip
FreeBSD-src-eb959580b55e142236682a8a38adf602bbe3aa77.tar.gz
MFC r299948
Set retval in the empty password case to avoid a path through the code that fails to set retval before falling through to the final return(). Reported by: emaste Reported by: Coverity CID: 1018711
Diffstat (limited to 'lib')
-rw-r--r--lib/libpam/modules/pam_unix/pam_unix.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/libpam/modules/pam_unix/pam_unix.c b/lib/libpam/modules/pam_unix/pam_unix.c
index 8c6b822..5403d5d 100644
--- a/lib/libpam/modules/pam_unix/pam_unix.c
+++ b/lib/libpam/modules/pam_unix/pam_unix.c
@@ -332,6 +332,7 @@ pam_sm_chauthtok(pam_handle_t *pamh, int flags,
* XXX check PAM_DISALLOW_NULL_AUTHTOK
*/
old_pass = "";
+ retval = PAM_SUCCESS;
} else {
retval = pam_get_authtok(pamh,
PAM_OLDAUTHTOK, &old_pass, NULL);
OpenPOWER on IntegriCloud