C99 compliance: time() always sets its return value in both places

(if present), even on error.

Pointed out by: Wojtek Lerch, on the Austin Group mailing-list

1 files changed, 7 insertions, 4 deletions

diff --git a/lib/libc/gen/time.c b/lib/libc/gen/time.c
index 2154833..4468b01 100644
--- a/lib/libc/gen/time.c
+++ b/lib/libc/gen/time.c
@@ -45,10 +45,13 @@ time(t)
 	time_t *t;
 {
 	struct timeval tt;
+	time_t retval;
 
 	if (gettimeofday(&tt, (struct timezone *)0) < 0)
-		return (-1);
-	if (t)
-		*t = tt.tv_sec;
-	return (tt.tv_sec);
+		retval = -1;
+	else
+		retval = tt.tv_sec;
+	if (t != NULL)
+		*t = retval;
+	return (retval);
 }