summaryrefslogtreecommitdiffstats
path: root/lib/msun/src/s_rint.c
diff options
context:
space:
mode:
authorbde <bde@FreeBSD.org>2008-01-19 16:37:57 +0000
committerbde <bde@FreeBSD.org>2008-01-19 16:37:57 +0000
commitaaee2ef564bf1c5fc99a37291522877aa33e15cc (patch)
tree412e3556c1d654fe9288dbb8e43183ac9e01626d /lib/msun/src/s_rint.c
parent1d78104fa012fbba92798ea6818421e3e000999a (diff)
downloadFreeBSD-src-aaee2ef564bf1c5fc99a37291522877aa33e15cc.zip
FreeBSD-src-aaee2ef564bf1c5fc99a37291522877aa33e15cc.tar.gz
Use STRICT_ASSIGN() instead of assorted direct volatile hacks to work
around assignments not working for gcc on i386. Now volatile hacks for rint() and rintf() don't needlessly pessimize so many arches and the remaining pessimizations (for arm and powerpc) can be avoided centrally. This cleans up after s_rint.c 1.3 and 1.13 and s_rintf.c 1.3 and 1.9: - s_rint.c 1.13 broke 1.3 by only using a volatile cast hack in 1 place when it was needed in 2 places, and the volatile cast hack stopped working with gcc-4. These bugs only affected correctness tests on i386 since i386 normally uses asm rint() and doesn't support the extra precision mode that would break assignments of doubles. - s_rintf.c 1.9 improved(?) on 1.3 by using a volatile variable hack instead of an extra-precision variable hack, but it declared 2 variables as volatile when only 1 variable needed to be volatile. This only affected speed tests on i386 since i386 uses asm rintf().
Diffstat (limited to 'lib/msun/src/s_rint.c')
-rw-r--r--lib/msun/src/s_rint.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/msun/src/s_rint.c b/lib/msun/src/s_rint.c
index 74a9331..571c17e 100644
--- a/lib/msun/src/s_rint.c
+++ b/lib/msun/src/s_rint.c
@@ -51,7 +51,7 @@ rint(double x)
i0 &= 0xfffe0000;
i0 |= ((i1|-i1)>>12)&0x80000;
SET_HIGH_WORD(x,i0);
- w = TWO52[sx]+x;
+ STRICT_ASSIGN(double,w,TWO52[sx]+x);
t = w-TWO52[sx];
GET_HIGH_WORD(i0,t);
SET_HIGH_WORD(t,(i0&0x7fffffff)|(sx<<31));
@@ -84,7 +84,7 @@ rint(double x)
if((i1&i)!=0) i1 = (i1&(~i))|((0x40000000)>>(j0-20));
}
INSERT_WORDS(x,i0,i1);
- *(volatile double *)&w = TWO52[sx]+x; /* clip any extra precision */
+ STRICT_ASSIGN(double,w,TWO52[sx]+x);
return w-TWO52[sx];
}
OpenPOWER on IntegriCloud