Unwind the _giant_mutex from pthread_detach(). When detaching a joiner thread

it's important the correct lock order is observed: lock first the joined and
then the joiner.

1 files changed, 8 insertions, 8 deletions

diff --git a/lib/libthr/thread/thr_detach.c b/lib/libthr/thread/thr_detach.c
index b11728e..23e985f 100644
--- a/lib/libthr/thread/thr_detach.c
+++ b/lib/libthr/thread/thr_detach.c
@@ -44,20 +44,19 @@ _pthread_detach(pthread_t pthread)
 	if (pthread == NULL || pthread->magic != PTHREAD_MAGIC)
 		return (EINVAL);
 
-	if (pthread->attr.flags & PTHREAD_DETACHED)
+	_SPINLOCK(&pthread->lock);
+
+	if (pthread->attr.flags & PTHREAD_DETACHED) {
+		_SPINUNLOCK(&pthread->lock);
 		return (EINVAL);
+	}
 
 	pthread->attr.flags |= PTHREAD_DETACHED;
 
-	/*
-	 * Defer signals to protect the scheduling queues from
-	 * access by the signal handler:
-	 */
-	GIANT_LOCK(curthread);
-
 	/* Check if there is a joiner: */
 	if (pthread->joiner != NULL) {
 		struct pthread	*joiner = pthread->joiner;
+		_thread_critical_enter(joiner);
 
 		/* Make the thread runnable: */
 		PTHREAD_NEW_STATE(joiner, PS_RUNNING);
@@ -71,9 +70,10 @@ _pthread_detach(pthread_t pthread)
 		 * Disconnect the joiner from the thread being detached:
 		 */
 		pthread->joiner = NULL;
+		_thread_critical_exit(joiner);
 	}
 
-	GIANT_UNLOCK(curthread);
+	_SPINUNLOCK(&pthread->lock);
 
 	return (0);
 }