General -Wall warning cleanup, part I.

Submitted-By: Kent Vander Velden <graphix@iastate.edu>

13 files changed, 25 insertions, 4 deletions

diff --git a/lib/libss/data.c b/lib/libss/data.c
index dd6341c..45e49d7 100644
--- a/lib/libss/data.c
+++ b/lib/libss/data.c
@@ -9,7 +9,7 @@
 #include "ss_internal.h"
 #include "copyright.h"
 
-const static char copyright[] =
+static const char copyright[] =
     "Copyright 1987, 1988, 1989 by the Massachusetts Institute of Technology";
 
 ss_data **_ss_table = (ss_data **)NULL;
diff --git a/lib/libss/error.c b/lib/libss/error.c
index 3946359..223d72a 100644
--- a/lib/libss/error.c
+++ b/lib/libss/error.c
@@ -6,6 +6,7 @@
  */
 
 #include <stdio.h>
+#include <stdlib.h>
 
 /*
  * Our standalone dpANS environment on the RT doesn't include any
@@ -25,6 +26,8 @@
 
 #undef ss_error
 
+extern void com_err_va __P(( ));
+
 char * ss_name(sci_idx)
     int sci_idx;
 {
diff --git a/lib/libss/execute_cmd.c b/lib/libss/execute_cmd.c
index d663b69..1bb0129 100644
--- a/lib/libss/execute_cmd.c
+++ b/lib/libss/execute_cmd.c
@@ -7,6 +7,7 @@
 #include "ss_internal.h"
 #include "copyright.h"
 #include <stdio.h>
+#include <stdlib.h>
 
 #ifndef lint
 static char const rcsid[] =
@@ -153,6 +154,7 @@ static int really_execute_command (sci_idx, argc, argv)
  * Notes:
  */
 
+int
 ss_execute_command(sci_idx, argv)
 	int sci_idx;
 	register char *argv[];
diff --git a/lib/libss/help.c b/lib/libss/help.c
index 0a8edd2..c6e99d8 100644
--- a/lib/libss/help.c
+++ b/lib/libss/help.c
@@ -7,6 +7,8 @@
 #include <sys/param.h>
 #include <sys/file.h>
 #include <sys/wait.h>
+#include <stdlib.h>
+#include <unistd.h>
 #include "ss_internal.h"
 #include "copyright.h"
 
diff --git a/lib/libss/invocation.c b/lib/libss/invocation.c
index 6f749df..513ec7d 100644
--- a/lib/libss/invocation.c
+++ b/lib/libss/invocation.c
@@ -3,6 +3,8 @@
  *
  * For copyright information, see copyright.h.
  */
+
+#include <stdlib.h>
 #include "ss_internal.h"
 #include "copyright.h"
 #define	size	sizeof(ss_data *)
diff --git a/lib/libss/list_rqs.c b/lib/libss/list_rqs.c
index 95fe904..14e7748 100644
--- a/lib/libss/list_rqs.c
+++ b/lib/libss/list_rqs.c
@@ -20,6 +20,7 @@ static char const twentyfive_spaces[26] =
     "                         ";
 static char const NL[2] = "\n";
 
+void
 ss_list_requests(argc, argv, sci_idx, info_ptr)
     int argc;
     char **argv;
diff --git a/lib/libss/listen.c b/lib/libss/listen.c
index 1633827..8420ad7 100644
--- a/lib/libss/listen.c
+++ b/lib/libss/listen.c
@@ -65,7 +65,6 @@ int ss_listen (sci_idx)
     register ss_data *info;
     sigtype (*sig_int)(), (*old_sig_cont)();
     char input[BUFSIZ];
-    char expanded_input[BUFSIZ];
     char buffer[BUFSIZ];
     char *end = buffer;
     int mask;
@@ -134,14 +133,14 @@ egress:
 }
 
 void ss_abort_subsystem(sci_idx, code)
-    int sci_idx;
+    int sci_idx, code;
 {
     ss_info(sci_idx)->abort = 1;
     ss_info(sci_idx)->exit_status = code;
 
 }
 
-int ss_quit(argc, argv, sci_idx, infop)
+void ss_quit(argc, argv, sci_idx, infop)
     int argc;
     char **argv;
     int sci_idx;
diff --git a/lib/libss/pager.c b/lib/libss/pager.c
index fac80bd..b419725 100644
--- a/lib/libss/pager.c
+++ b/lib/libss/pager.c
@@ -12,6 +12,7 @@
 #include <stdio.h>
 #include <sys/file.h>
 #include <signal.h>
+#include <unistd.h>
 
 static char MORE[] = "more";
 extern char *_ss_pager_name;
diff --git a/lib/libss/parse.c b/lib/libss/parse.c
index 4c91638..8a61ea8 100644
--- a/lib/libss/parse.c
+++ b/lib/libss/parse.c
@@ -4,6 +4,7 @@
  * For copyright info, see copyright.h.
  */
 
+#include <stdlib.h>
 #include "ss_internal.h"
 #include "copyright.h"
 
diff --git a/lib/libss/prompt.c b/lib/libss/prompt.c
index 60a5985..d6f5ff8 100644
--- a/lib/libss/prompt.c
+++ b/lib/libss/prompt.c
@@ -16,6 +16,7 @@
 static const char rcsid[] =
     "Header: prompt.c,v 1.2 89/01/18 18:27:02 raeburn Exp ";
 
+void
 ss_set_prompt(sci_idx, new_prompt)
      int sci_idx;
      char *new_prompt;
diff --git a/lib/libss/request_tbl.c b/lib/libss/request_tbl.c
index 8dcb583..b860064 100644
--- a/lib/libss/request_tbl.c
+++ b/lib/libss/request_tbl.c
@@ -4,11 +4,13 @@
  * For copyright information, see copyright.h.
  */
 
+#include <stdlib.h>
 #include "copyright.h"
 #include "ss_internal.h"
 
 #define ssrt ss_request_table	/* for some readable code... */
 
+void
 ss_add_request_table(sci_idx, rqtbl_ptr, position, code_ptr)
 	int sci_idx;
 	ssrt *rqtbl_ptr;
@@ -41,6 +43,7 @@ ss_add_request_table(sci_idx, rqtbl_ptr, position, code_ptr)
 	*code_ptr = 0;
 }
 
+void
 ss_delete_request_table(sci_idx, rqtbl_ptr, code_ptr)
      int sci_idx;
      ssrt *rqtbl_ptr;
diff --git a/lib/libss/requests.c b/lib/libss/requests.c
index e4143f4..7aaf4f5 100644
--- a/lib/libss/requests.c
+++ b/lib/libss/requests.c
@@ -15,6 +15,7 @@
 /*
  * ss_self_identify -- assigned by default to the "." request
  */
+void
 DECLARE(ss_self_identify)
 {
      register ss_data *info = ss_info(sci_idx);
@@ -25,6 +26,7 @@ DECLARE(ss_self_identify)
 /*
  * ss_subsystem_name -- print name of subsystem
  */
+void
 DECLARE(ss_subsystem_name)
 {
      printf("%s\n", ss_info(sci_idx)->subsystem_name);
@@ -33,6 +35,7 @@ DECLARE(ss_subsystem_name)
 /*
  * ss_subsystem_version -- print version of subsystem
  */
+void
 DECLARE(ss_subsystem_version)
 {
      printf("%s\n", ss_info(sci_idx)->subsystem_version);
@@ -42,6 +45,7 @@ DECLARE(ss_subsystem_version)
  * ss_unimplemented -- routine not implemented (should be
  * set up as (dont_list,dont_summarize))
  */
+void
 DECLARE(ss_unimplemented)
 {
      ss_perror(sci_idx, SS_ET_UNIMPLEMENTED, "");
diff --git a/lib/libss/ss_internal.h b/lib/libss/ss_internal.h
index 5e43717..e613488 100644
--- a/lib/libss/ss_internal.h
+++ b/lib/libss/ss_internal.h
@@ -105,9 +105,11 @@ void ss_page_stdin();
 extern ss_data **_ss_table;
 extern char *ss_et_msgs[];
 
+#ifndef __FreeBSD__
 extern pointer malloc PROTOTYPE((unsigned));
 extern pointer realloc PROTOTYPE((pointer, unsigned));
 extern pointer calloc PROTOTYPE((unsigned, unsigned));
 extern int exit PROTOTYPE((int));
+#endif
 
 #endif /* _ss_internal_h */