diff options
author | deischen <deischen@FreeBSD.org> | 2000-03-15 13:59:27 +0000 |
---|---|---|
committer | deischen <deischen@FreeBSD.org> | 2000-03-15 13:59:27 +0000 |
commit | 228266df1122dd0b3102d45629ae1e0d7ae42f31 (patch) | |
tree | dbe86a4d7c4333049e4c8db5b8b117b8ae2e6c7c /lib/libpthread/thread/thr_kern.c | |
parent | 87a0ee8fd64ec5f1e02e3bef4a0de750d7bede50 (diff) | |
download | FreeBSD-src-228266df1122dd0b3102d45629ae1e0d7ae42f31.zip FreeBSD-src-228266df1122dd0b3102d45629ae1e0d7ae42f31.tar.gz |
Fix pthread_suspend_np/pthread_resume_np. For the record, suspending a
thread waiting on an event (I/O, condvar, etc) will, when resumed using
pthread_resume_np, return with EINTR. For example, suspending and resuming
a thread blocked on read() will not requeue the thread for the read, but
will return -1 with errno = EINTR. If the suspended thread is in a critical
region, the thread is suspended as soon as it leaves the critical region.
Fix a bogon in pthread_kill() where a signal was being delivered twice
to threads waiting in sigwait().
Reported by (suspend/resume bug): jdp
Reviewed by: jasone
Diffstat (limited to 'lib/libpthread/thread/thr_kern.c')
-rw-r--r-- | lib/libpthread/thread/thr_kern.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/libpthread/thread/thr_kern.c b/lib/libpthread/thread/thr_kern.c index 3e0ff17..8b333e4 100644 --- a/lib/libpthread/thread/thr_kern.c +++ b/lib/libpthread/thread/thr_kern.c @@ -184,8 +184,10 @@ __asm__("fnsave %0": :"m"(*fdata)); switch (_thread_run->state) { case PS_DEAD: case PS_STATE_MAX: /* to silence -Wall */ + case PS_SUSPENDED: /* - * Dead threads are not placed in any queue: + * Dead and suspended threads are not placed + * in any queue: */ break; @@ -227,7 +229,6 @@ __asm__("fnsave %0": :"m"(*fdata)); case PS_SIGSUSPEND: case PS_SIGTHREAD: case PS_SIGWAIT: - case PS_SUSPENDED: case PS_WAIT_WAIT: /* No timeouts for these states: */ _thread_run->wakeup_time.tv_sec = -1; |