diff options
| author | davidxu <davidxu@FreeBSD.org> | 2003-07-07 04:28:23 +0000 |
|---|---|---|
| committer | davidxu <davidxu@FreeBSD.org> | 2003-07-07 04:28:23 +0000 |
| commit | 8aa4e2d6856d1eed699b30ccca6163f8e501e183 (patch) | |
| tree | 6539674ba4c0ff3018faf64006ac81eb9090ec5f /lib/libpthread/thread/thr_attr_get_np.c | |
| parent | e95dd66c1f7fd662d47b34b5d83f1dcaa8b150e3 (diff) | |
| download | FreeBSD-src-8aa4e2d6856d1eed699b30ccca6163f8e501e183.zip FreeBSD-src-8aa4e2d6856d1eed699b30ccca6163f8e501e183.tar.gz | |
Avoid accessing user provided parameters in critical region.
Reviewed by: deischen
Diffstat (limited to 'lib/libpthread/thread/thr_attr_get_np.c')
| -rw-r--r-- | lib/libpthread/thread/thr_attr_get_np.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/libpthread/thread/thr_attr_get_np.c b/lib/libpthread/thread/thr_attr_get_np.c index 4431824..e844acb 100644 --- a/lib/libpthread/thread/thr_attr_get_np.c +++ b/lib/libpthread/thread/thr_attr_get_np.c @@ -37,6 +37,7 @@ int _pthread_attr_get_np(pthread_t pid, pthread_attr_t *dst) { struct pthread *curthread; + struct pthread_attr attr; int ret; if (pid == NULL || dst == NULL || *dst == NULL) @@ -45,9 +46,9 @@ _pthread_attr_get_np(pthread_t pid, pthread_attr_t *dst) curthread = _get_curthread(); if ((ret = _thr_ref_add(curthread, pid, /*include dead*/0)) != 0) return (ret); - - memcpy(*dst, &pid->attr, sizeof(struct pthread_attr)); + attr = pid->attr; _thr_ref_delete(curthread, pid); + memcpy(*dst, &attr, sizeof(struct pthread_attr)); return (0); } |
