summaryrefslogtreecommitdiffstats
path: root/lib/libfetch
diff options
context:
space:
mode:
authoreadler <eadler@FreeBSD.org>2012-09-14 12:15:13 +0000
committereadler <eadler@FreeBSD.org>2012-09-14 12:15:13 +0000
commitf1f9181f8f4d1c028699c9065064f1bf4f47b703 (patch)
tree5e55b280e2256b535c75f8df48efc43ec5760116 /lib/libfetch
parent0ccf4838d7a8b4da2c3beaac7ea1fd977aa0ed11 (diff)
downloadFreeBSD-src-f1f9181f8f4d1c028699c9065064f1bf4f47b703.zip
FreeBSD-src-f1f9181f8f4d1c028699c9065064f1bf4f47b703.tar.gz
Adding missing return statements during error conditions.
PR: kern/171187 Submitted by: Mark Johnston <markjdb@gmail.com> Reviewed by: des Approved by: cperciva MFC after: 2 weeks
Diffstat (limited to 'lib/libfetch')
-rw-r--r--lib/libfetch/file.c10
1 files changed, 8 insertions, 2 deletions
diff --git a/lib/libfetch/file.c b/lib/libfetch/file.c
index 8569ff3..8c1d404 100644
--- a/lib/libfetch/file.c
+++ b/lib/libfetch/file.c
@@ -50,12 +50,15 @@ fetchXGetFile(struct url *u, struct url_stat *us, const char *flags)
f = fopen(u->doc, "r");
- if (f == NULL)
+ if (f == NULL) {
fetch_syserr();
+ return (NULL);
+ }
if (u->offset && fseeko(f, u->offset, SEEK_SET) == -1) {
fclose(f);
fetch_syserr();
+ return (NULL);
}
fcntl(fileno(f), F_SETFD, FD_CLOEXEC);
@@ -78,12 +81,15 @@ fetchPutFile(struct url *u, const char *flags)
else
f = fopen(u->doc, "w+");
- if (f == NULL)
+ if (f == NULL) {
fetch_syserr();
+ return (NULL);
+ }
if (u->offset && fseeko(f, u->offset, SEEK_SET) == -1) {
fclose(f);
fetch_syserr();
+ return (NULL);
}
fcntl(fileno(f), F_SETFD, FD_CLOEXEC);
OpenPOWER on IntegriCloud