diff options
| author | delphij <delphij@FreeBSD.org> | 2017-07-03 02:14:42 +0000 |
|---|---|---|
| committer | delphij <delphij@FreeBSD.org> | 2017-07-03 02:14:42 +0000 |
| commit | f93ff01b1f3fe00dbebffc3bf4d31e3120a32b9f (patch) | |
| tree | a2aefdc6b4ad9536264423ce41dae7a811151139 /lib/libc | |
| parent | 79c189ac9caf9e3529acc35f3f774a7cd4bda7e5 (diff) | |
| download | FreeBSD-src-f93ff01b1f3fe00dbebffc3bf4d31e3120a32b9f.zip FreeBSD-src-f93ff01b1f3fe00dbebffc3bf4d31e3120a32b9f.tar.gz | |
MFC r320494: Fix double free by reverting r300385 and r300624 which was
false positive reported by cppcheck.
Diffstat (limited to 'lib/libc')
| -rw-r--r-- | lib/libc/rpc/getnetconfig.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/libc/rpc/getnetconfig.c b/lib/libc/rpc/getnetconfig.c index 38754bb..6d668bf 100644 --- a/lib/libc/rpc/getnetconfig.c +++ b/lib/libc/rpc/getnetconfig.c @@ -692,7 +692,7 @@ static struct netconfig * dup_ncp(struct netconfig *ncp) { struct netconfig *p; - char *tmp, *tmp2; + char *tmp; u_int i; if ((tmp=malloc(MAXNETCONFIGLINE)) == NULL) @@ -701,7 +701,6 @@ dup_ncp(struct netconfig *ncp) free(tmp); return(NULL); } - tmp2 = tmp; /* * First we dup all the data from matched netconfig buffer. Then we * adjust some of the member pointer to a pre-allocated buffer where @@ -723,7 +722,6 @@ dup_ncp(struct netconfig *ncp) if (p->nc_lookups == NULL) { free(p->nc_netid); free(p); - free(tmp2); return(NULL); } for (i=0; i < p->nc_nlookups; i++) { |
