summaryrefslogtreecommitdiffstats
path: root/lib/libc
diff options
context:
space:
mode:
authornectar <nectar@FreeBSD.org>2004-01-06 18:43:31 +0000
committernectar <nectar@FreeBSD.org>2004-01-06 18:43:31 +0000
commitd76901e917b0568cf0ea0319ff283018bdf31a26 (patch)
tree3d52d4a254b752fc0e89929bd1e3db7c57baab7b /lib/libc
parenta455b2e93e7dadc05f627dc75887505b3fd011e4 (diff)
downloadFreeBSD-src-d76901e917b0568cf0ea0319ff283018bdf31a26.zip
FreeBSD-src-d76901e917b0568cf0ea0319ff283018bdf31a26.tar.gz
Avoid undefined behavior:
foo[i] = bar[++i]; /* Which operator [] will be evaluated first? */
Diffstat (limited to 'lib/libc')
-rw-r--r--lib/libc/posix1e/acl_delete_entry.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/libc/posix1e/acl_delete_entry.c b/lib/libc/posix1e/acl_delete_entry.c
index e867ff6..3a7609a 100644
--- a/lib/libc/posix1e/acl_delete_entry.c
+++ b/lib/libc/posix1e/acl_delete_entry.c
@@ -61,9 +61,9 @@ acl_delete_entry(acl_t acl, acl_entry_t entry_d)
if ((acl->ats_acl.acl_entry[i].ae_tag == entry_d->ae_tag) &&
(acl->ats_acl.acl_entry[i].ae_id == entry_d->ae_id)) {
/* ...shift the remaining entries... */
- while (i < acl->ats_acl.acl_cnt - 1)
+ for (; i < acl->ats_acl.acl_cnt - 1; ++i)
acl->ats_acl.acl_entry[i] =
- acl->ats_acl.acl_entry[++i];
+ acl->ats_acl.acl_entry[i];
/* ...drop the count and zero the unused entry... */
acl->ats_acl.acl_cnt--;
bzero(&acl->ats_acl.acl_entry[i],
OpenPOWER on IntegriCloud