diff options
| author | jilles <jilles@FreeBSD.org> | 2012-09-29 11:54:34 +0000 |
|---|---|---|
| committer | jilles <jilles@FreeBSD.org> | 2012-09-29 11:54:34 +0000 |
| commit | fba61ef227067b4f30ac71dee816dd39abee1c8e (patch) | |
| tree | 89610d7c33533a1abd5218d8db331931ee9e6327 /lib/libc/yp | |
| parent | 576f4f1ec84faf13f14984bdf7f8f07357e3ab02 (diff) | |
| download | FreeBSD-src-fba61ef227067b4f30ac71dee816dd39abee1c8e.zip FreeBSD-src-fba61ef227067b4f30ac71dee816dd39abee1c8e.tar.gz | |
libc: Use O_CLOEXEC for various internal file descriptors.
This fixes a race condition where another thread may fork() before CLOEXEC
is set, unintentionally passing the descriptor to the child process.
This commit only adds O_CLOEXEC flags to open() or openat() calls where no
fcntl(fd, F_SETFD, FD_CLOEXEC) follows. The separate fcntl() call still
leaves a race window so it should be fixed later.
Diffstat (limited to 'lib/libc/yp')
| -rw-r--r-- | lib/libc/yp/yplib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/libc/yp/yplib.c b/lib/libc/yp/yplib.c index 3dfc0aa..1778c6a 100644 --- a/lib/libc/yp/yplib.c +++ b/lib/libc/yp/yplib.c @@ -375,7 +375,7 @@ again: ysd->dom_socket = -1; } snprintf(path, sizeof(path), "%s/%s.%d", BINDINGDIR, dom, 2); - if ((fd = _open(path, O_RDONLY)) == -1) { + if ((fd = _open(path, O_RDONLY | O_CLOEXEC)) == -1) { /* no binding file, YP is dead. */ /* Try to bring it back to life. */ _close(fd); |
