summaryrefslogtreecommitdiffstats
path: root/lib/libc/stdlib/getsubopt.c
diff options
context:
space:
mode:
authoralc <alc@FreeBSD.org>2010-04-25 20:40:45 +0000
committeralc <alc@FreeBSD.org>2010-04-25 20:40:45 +0000
commit019a1d16bacaa7783b857c309ce61d655e899904 (patch)
treeec9ad7b26fa81cd6cf0b255dbb08eeabdf74fed4 /lib/libc/stdlib/getsubopt.c
parent8156e27dd79d633bbb41f44cf030e93cdcd15889 (diff)
downloadFreeBSD-src-019a1d16bacaa7783b857c309ce61d655e899904.zip
FreeBSD-src-019a1d16bacaa7783b857c309ce61d655e899904.tar.gz
Clearing a page table entry's accessed bit (PG_A) and setting the
page's PG_REFERENCED flag in pmap_protect() can't really be justified. In contrast to pmap_remove() or pmap_remove_all(), the mapping is not being destroyed, so the notion that the page was accessed is not lost. Moreover, clearing the page table entry's accessed bit and setting the page's PG_REFERENCED flag can throw off the page daemon's activity count calculation. Finally, in my tests, I found that 15% of the atomic memory operations being performed by pmap_protect() were only to clear PG_A, and not change protection. This could, by itself, be fixed, but I don't see the point given the above argument. Remove a comment from pmap_protect_pde() that is no longer meaningful after the above change.
Diffstat (limited to 'lib/libc/stdlib/getsubopt.c')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud