diff options
| author | jilles <jilles@FreeBSD.org> | 2012-09-29 11:54:34 +0000 |
|---|---|---|
| committer | jilles <jilles@FreeBSD.org> | 2012-09-29 11:54:34 +0000 |
| commit | fba61ef227067b4f30ac71dee816dd39abee1c8e (patch) | |
| tree | 89610d7c33533a1abd5218d8db331931ee9e6327 /lib/libc/locale | |
| parent | 576f4f1ec84faf13f14984bdf7f8f07357e3ab02 (diff) | |
| download | FreeBSD-src-fba61ef227067b4f30ac71dee816dd39abee1c8e.zip FreeBSD-src-fba61ef227067b4f30ac71dee816dd39abee1c8e.tar.gz | |
libc: Use O_CLOEXEC for various internal file descriptors.
This fixes a race condition where another thread may fork() before CLOEXEC
is set, unintentionally passing the descriptor to the child process.
This commit only adds O_CLOEXEC flags to open() or openat() calls where no
fcntl(fd, F_SETFD, FD_CLOEXEC) follows. The separate fcntl() call still
leaves a race window so it should be fixed later.
Diffstat (limited to 'lib/libc/locale')
| -rw-r--r-- | lib/libc/locale/ldpart.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/libc/locale/ldpart.c b/lib/libc/locale/ldpart.c index ea7b388..ccf5e7f 100644 --- a/lib/libc/locale/ldpart.c +++ b/lib/libc/locale/ldpart.c @@ -87,7 +87,7 @@ __part_load_locale(const char *name, strcat(filename, name); strcat(filename, "/"); strcat(filename, category_filename); - if ((fd = _open(filename, O_RDONLY)) < 0) + if ((fd = _open(filename, O_RDONLY | O_CLOEXEC)) < 0) return (_LDP_ERROR); if (_fstat(fd, &st) != 0) goto bad_locale; |
