Remove the warnx() from kgdb_lookup() so that we don't emit a warning about

optional symbols that are missing (e.g. kgdb complains about _stoppcbs and
_stopped_cpus on UP kernels).  Instead, callers that really want their
symbols to be present now do explicitly warnx() about the missing symbol.

2 files changed, 10 insertions, 6 deletions

diff --git a/gnu/usr.bin/gdb/kgdb/kthr.c b/gnu/usr.bin/gdb/kgdb/kthr.c
index c114515..4c51c0e 100644
--- a/gnu/usr.bin/gdb/kgdb/kthr.c
+++ b/gnu/usr.bin/gdb/kgdb/kthr.c
@@ -60,10 +60,8 @@ kgdb_lookup(const char *sym)
 
 	nl[0].n_name = (char *)(uintptr_t)sym;
 	nl[1].n_name = NULL;
-	if (kvm_nlist(kvm, nl) != 0) {
-		warnx("kvm_nlist(%s): %s", sym, kvm_geterr(kvm));
+	if (kvm_nlist(kvm, nl) != 0)
 		return (0);
-	}
 	return (nl[0].n_value);
 }
 
@@ -82,13 +80,17 @@ kgdb_thr_init(void)
 	uintptr_t addr, paddr;
 
 	addr = kgdb_lookup("_allproc");
-	if (addr == 0)
+	if (addr == 0) {
+		warnx("kvm_nlist(_allproc): %s", kvm_geterr(kvm));
 		return (NULL);
+	}
 	kvm_read(kvm, addr, &paddr, sizeof(paddr));
 
 	dumppcb = kgdb_lookup("_dumppcb");
-	if (dumppcb == 0)
+	if (dumppcb == 0) {
+		warnx("kvm_nlist(_dumppcb): %s", kvm_geterr(kvm));
 		return (NULL);
+	}
 
 	addr = kgdb_lookup("_dumptid");
 	if (addr != 0)
diff --git a/gnu/usr.bin/gdb/kgdb/trgt_i386.c b/gnu/usr.bin/gdb/kgdb/trgt_i386.c
index c3581b5..de15a63 100644
--- a/gnu/usr.bin/gdb/kgdb/trgt_i386.c
+++ b/gnu/usr.bin/gdb/kgdb/trgt_i386.c
@@ -141,8 +141,10 @@ kgdb_trgt_fetch_tss(void)
 	 */ 
 	if (trunc_page(tss) == 0xffc00000) {
 		addr = kgdb_lookup("_cpu0prvpage");
-		if (addr == 0)
+		if (addr == 0) {
+			warnx("kvm_nlist(_cpu0prvpage): %s", kvm_geterr(kvm));
 			return (0);
+		}
 		if (kvm_read(kvm, addr, &cpu0prvpage, sizeof(cpu0prvpage)) !=
 		    sizeof(cpu0prvpage)) {
 			warnx("kvm_read: %s", kvm_geterr(kvm));