diff options
| author | jhb <jhb@FreeBSD.org> | 2015-09-29 15:47:42 +0000 |
|---|---|---|
| committer | jhb <jhb@FreeBSD.org> | 2015-09-29 15:47:42 +0000 |
| commit | eba92cd9052b7330c05411fe4c937afcb71f12bb (patch) | |
| tree | eb807ca95b0383164de45931722c3c728b79454c /gnu | |
| parent | 00e9f99f769be6937cece44e2a45afe2835ffa41 (diff) | |
| download | FreeBSD-src-eba92cd9052b7330c05411fe4c937afcb71f12bb.zip FreeBSD-src-eba92cd9052b7330c05411fe4c937afcb71f12bb.tar.gz | |
When XSAVE support was added on amd64, the FPU save area was moved
out of 'struct pcb' and into a variable-sized region after the
structure. The kgdb code currently only reads the pcb. It does not
read in the FPU save area but instead passes stack garbage as the
FPU's saved context. Fixing this would mean determining the proper
size of the area and fetching it. However, this state is not saved
for running CPUs in stoppcbs[], so the callback would also have to
know to ignore those pcbs. Instead, just remove the call since it is
of limited usefulness. It results in kgdb reporting the state of the
FPU/SIMD registers in userland, not their current values in the kernel.
In particular, it does not report the correct state for any code in
the kernel which does use the FPU and would report incorrect values
in that case.
Reviewed by: kib
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D3743
Diffstat (limited to 'gnu')
| -rw-r--r-- | gnu/usr.bin/gdb/kgdb/trgt_amd64.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/gnu/usr.bin/gdb/kgdb/trgt_amd64.c b/gnu/usr.bin/gdb/kgdb/trgt_amd64.c index cb13d71..104d8c5 100644 --- a/gnu/usr.bin/gdb/kgdb/trgt_amd64.c +++ b/gnu/usr.bin/gdb/kgdb/trgt_amd64.c @@ -72,7 +72,6 @@ kgdb_trgt_fetch_registers(int regno __unused) supply_register(AMD64_R8_REGNUM + 6, (char *)&pcb.pcb_r14); supply_register(AMD64_R15_REGNUM, (char *)&pcb.pcb_r15); supply_register(AMD64_RIP_REGNUM, (char *)&pcb.pcb_rip); - amd64_supply_fxsave(current_regcache, -1, (struct fpusave *)(&pcb + 1)); } void |
