summaryrefslogtreecommitdiffstats
path: root/etc/rc.d/Makefile
diff options
context:
space:
mode:
authorbmilekic <bmilekic@FreeBSD.org>2003-07-30 18:55:15 +0000
committerbmilekic <bmilekic@FreeBSD.org>2003-07-30 18:55:15 +0000
commit7c379c85d8068f5ddb6f8fdaf8886220bd3a6959 (patch)
tree5e775bcf772364d8869f90d2d91a4f9301ed1794 /etc/rc.d/Makefile
parentfc6d1980ccfd4a7b38ccbaf16d7081451124545f (diff)
downloadFreeBSD-src-7c379c85d8068f5ddb6f8fdaf8886220bd3a6959.zip
FreeBSD-src-7c379c85d8068f5ddb6f8fdaf8886220bd3a6959.tar.gz
Plug a race and a leak in UMA.
1) The race has to do with zone destruction. From the zone destructor we would lock the zone, set the working set size to 0, then unlock the zone, drain it, and then free the structure. Within the window following the working-set-size set to 0 and unlocking of the zone and the point where in zone_drain we re-acquire the zone lock, the uma timer routine could have fired off and changed the working set size to something non-zero, thereby potentially preventing us from completely freeing slabs before destroying the zone (and thus leaking them). 2) The leak has to do with zone destruction as well. When destroying a zone we would take care to free all the buckets cached in the zone, but although we would drain the pcpu cache buckets, we would not free them. This resulted in leaking a couple of bucket structures (512 bytes each) per cpu on SMP during zone destruction. While I'm here, also silence GCC warnings by turning uma_slab_alloc() from inline to real function. It's too big to be an inline. Reviewed by: JeffR
Diffstat (limited to 'etc/rc.d/Makefile')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud