summaryrefslogtreecommitdiffstats
path: root/contrib/netbsd-tests
diff options
context:
space:
mode:
authorngie <ngie@FreeBSD.org>2016-05-04 07:39:23 +0000
committerngie <ngie@FreeBSD.org>2016-05-04 07:39:23 +0000
commit5845c903853fc8d7d7d1011fba75a41e29b351f0 (patch)
tree4f1571b34211a5cd7b9c9001986653250690e517 /contrib/netbsd-tests
parentc952e2bbbe7be5296f100c27ccb0ebde46cd55b5 (diff)
downloadFreeBSD-src-5845c903853fc8d7d7d1011fba75a41e29b351f0.zip
FreeBSD-src-5845c903853fc8d7d7d1011fba75a41e29b351f0.tar.gz
MFC r298366:
Fix coverity issues with contrib/netbsd-tests/lib/libc/sys/t_connect.c - Ensure socket(2) calls succeed - Don't leak slist allocated by earlier socket(2) call CID: 976773, 1251405
Diffstat (limited to 'contrib/netbsd-tests')
-rw-r--r--contrib/netbsd-tests/lib/libc/sys/t_connect.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/contrib/netbsd-tests/lib/libc/sys/t_connect.c b/contrib/netbsd-tests/lib/libc/sys/t_connect.c
index e492206..896b490 100644
--- a/contrib/netbsd-tests/lib/libc/sys/t_connect.c
+++ b/contrib/netbsd-tests/lib/libc/sys/t_connect.c
@@ -56,6 +56,11 @@ ATF_TC_BODY(connect_low_port, tc)
slist = socket(AF_INET, SOCK_STREAM, 0);
sd = socket(AF_INET, SOCK_STREAM, 0);
+#ifdef __FreeBSD__
+ ATF_REQUIRE(sd > 0);
+ ATF_REQUIRE(slist > 0);
+#endif
+
/* bind listening socket */
memset(&sinlist, 0, sizeof(sinlist));
sinlist.sin_family = AF_INET;
@@ -92,6 +97,9 @@ ATF_TC_BODY(connect_low_port, tc)
ATF_REQUIRE(ntohs(sin.sin_port) <= IPPORT_RESERVEDMAX);
close(sd);
+#ifdef __FreeBSD__
+ close(slist);
+#endif
}
ATF_TP_ADD_TCS(tp)
OpenPOWER on IntegriCloud