diff options
author | dim <dim@FreeBSD.org> | 2014-12-04 01:10:50 +0000 |
---|---|---|
committer | dim <dim@FreeBSD.org> | 2014-12-04 01:10:50 +0000 |
commit | 856a79343271cb58623cc9f78fafa2d9c37b002a (patch) | |
tree | 616036877e3db77b527042f5f3c31e905097b2f6 /contrib/libc++/include/regex | |
parent | b431d8bfcf00b54b75c7998064e774897db68c97 (diff) | |
download | FreeBSD-src-856a79343271cb58623cc9f78fafa2d9c37b002a.zip FreeBSD-src-856a79343271cb58623cc9f78fafa2d9c37b002a.tar.gz |
MFC r274922:
Fix the following -Werror warning from clang 3.5.0, while building the
ath kernel module:
sys/dev/ath/ath_hal/ar5212/ar5212_reset.c:2642:7: error: taking the absolute value of unsigned type 'unsigned int' has no effect [-Werror,-Wabsolute-value]
if (abs(lp[0] * EEP_SCALE - target) < EEP_DELTA) {
^
sys/dev/ath/ah_osdep.h:74:18: note: expanded from macro 'abs'
#define abs(_a) __builtin_abs(_a)
^
sys/dev/ath/ath_hal/ar5212/ar5212_reset.c:2642:7: note: remove the call to '__builtin_abs' since unsigned values cannot be negative
sys/dev/ath/ah_osdep.h:74:18: note: expanded from macro 'abs'
#define abs(_a) __builtin_abs(_a)
^
1 error generated.
This warning occurs because both lp[0] and target are unsigned, so the
subtraction expression is also unsigned, and calling abs() is a no-op.
However, the intention was to look at the absolute difference between
the two unsigned quantities. Introduce a small static function to
clarify what we're doing, and call that instead.
Reviewed by: adrian
Differential Revision: https://reviews.freebsd.org/D1212
Diffstat (limited to 'contrib/libc++/include/regex')
0 files changed, 0 insertions, 0 deletions