diff options
author | dim <dim@FreeBSD.org> | 2016-09-07 19:21:52 +0000 |
---|---|---|
committer | dim <dim@FreeBSD.org> | 2016-09-07 19:21:52 +0000 |
commit | 83216cdbb72b65e649ebf7582ea72cb089229b41 (patch) | |
tree | 64c271e4fde095bd846b545cd0ac949f4ece97ea /contrib/diff/src/util.c | |
parent | 5af3f0b5e8740ebbf55d49df9c23dc25ea3616c0 (diff) | |
download | FreeBSD-src-83216cdbb72b65e649ebf7582ea72cb089229b41.zip FreeBSD-src-83216cdbb72b65e649ebf7582ea72cb089229b41.tar.gz |
MFC r305388:
With clang 3.9.0, compiling uplcom results in the following warnings:
sys/dev/usb/serial/uplcom.c:543:29: error: implicit conversion from 'int' to 'int8_t' (aka 'signed char') changes value from 192 to -64 [-Werror,-Wconstant-conversion]
if (uplcom_pl2303_do(udev, UT_READ_VENDOR_DEVICE, UPLCOM_SET_REQUEST, 0x8484, 0, 1)
~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~
sys/dev/usb/usb.h:179:53: note: expanded from macro 'UT_READ_VENDOR_DEVICE'
#define UT_READ_VENDOR_DEVICE (UT_READ | UT_VENDOR | UT_DEVICE)
~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
This is because UT_READ is 0x80, so the int8_t argument is wrapped to a
negative value. Fix this by using uint8_t instead.
Reviewed by: imp, hselasky
Differential Revision: https://reviews.freebsd.org/D7776
Diffstat (limited to 'contrib/diff/src/util.c')
0 files changed, 0 insertions, 0 deletions