diff options
author | dim <dim@FreeBSD.org> | 2016-09-07 19:02:47 +0000 |
---|---|---|
committer | dim <dim@FreeBSD.org> | 2016-09-07 19:02:47 +0000 |
commit | 2df99ac12ab3bf931dc78958d1f3b187083f419b (patch) | |
tree | 9e1b9dbe56a6ee28411ad1c1bcc33aa7eb051bbd /contrib/diff/src/normal.c | |
parent | 5fce709aa897997ab2a29c000342cabab00ae643 (diff) | |
download | FreeBSD-src-2df99ac12ab3bf931dc78958d1f3b187083f419b.zip FreeBSD-src-2df99ac12ab3bf931dc78958d1f3b187083f419b.tar.gz |
MFC r305345:
With clang 3.9.0, compiling ppbus(4) results in the following warnings:
sys/dev/ppbus/ppb_1284.c:296:46: error: implicit conversion from 'int'
to 'char' changes value from 144 to -112 [-Werror,-Wconstant-conversion]
if ((error = do_peripheral_wait(bus, SELECT | nBUSY, 0))) {
~~~~~~~~~~~~~~~~~~ ~~~~~~~^~~~~~~
sys/dev/ppbus/ppb_1284.c:785:48: error: implicit conversion from 'int'
to 'char' changes value from 240 to -16 [-Werror,-Wconstant-conversion]
if (do_1284_wait(bus, nACK | SELECT | PERROR | nBUSY,
~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
sys/dev/ppbus/ppb_1284.c:786:29: error: implicit conversion from 'int'
to 'char' changes value from 240 to -16 [-Werror,-Wconstant-conversion]
nACK | SELECT | PERROR | nBUSY)) {
~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
This is because nBUSY is 0x80, so the plain char argument is wrapped to
a negative value. Fix this in a minimal fashion, by using uint8_t in a
few places.
Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D7771
Diffstat (limited to 'contrib/diff/src/normal.c')
0 files changed, 0 insertions, 0 deletions