summaryrefslogtreecommitdiffstats
path: root/cddl
diff options
context:
space:
mode:
authormav <mav@FreeBSD.org>2015-10-18 18:25:00 +0000
committermav <mav@FreeBSD.org>2015-10-18 18:25:00 +0000
commit93afe7bdc606349a681a0e5518afa7640d4ee4d6 (patch)
treeaf8c5a3e5f105b129e2da2a4b1e2682dd93ac03e /cddl
parent1c4271d11bbe87be208c21d7f42a533582b2a2e4 (diff)
downloadFreeBSD-src-93afe7bdc606349a681a0e5518afa7640d4ee4d6.zip
FreeBSD-src-93afe7bdc606349a681a0e5518afa7640d4ee4d6.tar.gz
Reduce diff from upstream.
Should be no functional change.
Diffstat (limited to 'cddl')
-rw-r--r--cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c26
1 files changed, 13 insertions, 13 deletions
diff --git a/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c b/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
index 1854160..bbab81b 100644
--- a/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
+++ b/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_pool.c
@@ -3729,17 +3729,18 @@ zpool_history_unpack(char *buf, uint64_t bytes_read, uint64_t *leftover,
int
zpool_get_history(zpool_handle_t *zhp, nvlist_t **nvhisp)
{
- char *buf = NULL;
- uint64_t bufsize = HIS_BUF_LEN_DEF;
+ char *buf;
+ uint64_t buflen = HIS_BUF_LEN_DEF;
uint64_t off = 0;
nvlist_t **records = NULL;
uint_t numrecords = 0;
int err, i;
- if ((buf = malloc(bufsize)) == NULL)
+ buf = malloc(buflen);
+ if (buf == NULL)
return (ENOMEM);
do {
- uint64_t bytes_read = bufsize;
+ uint64_t bytes_read = buflen;
uint64_t leftover;
if ((err = get_history(zhp, buf, &off, &bytes_read)) != 0)
@@ -3753,18 +3754,16 @@ zpool_get_history(zpool_handle_t *zhp, nvlist_t **nvhisp)
&leftover, &records, &numrecords)) != 0)
break;
off -= leftover;
-
- /*
- * If the history block is too big, double the buffer
- * size and try again.
- */
if (leftover == bytes_read) {
+ /*
+ * no progress made, because buffer is not big enough
+ * to hold this record; resize and retry.
+ */
+ buflen *= 2;
free(buf);
buf = NULL;
-
- bufsize <<= 1;
- if ((bufsize >= HIS_BUF_LEN_MAX) ||
- ((buf = malloc(bufsize)) == NULL)) {
+ if ((buflen >= HIS_BUF_LEN_MAX) ||
+ ((buf = malloc(buflen)) == NULL)) {
err = ENOMEM;
break;
}
@@ -3772,6 +3771,7 @@ zpool_get_history(zpool_handle_t *zhp, nvlist_t **nvhisp)
/* CONSTCOND */
} while (1);
+
free(buf);
if (!err) {
OpenPOWER on IntegriCloud