summaryrefslogtreecommitdiffstats
path: root/bin
diff options
context:
space:
mode:
authornate <nate@FreeBSD.org>1998-10-03 19:17:11 +0000
committernate <nate@FreeBSD.org>1998-10-03 19:17:11 +0000
commit75914bbe383daf52ea7fc212276685cc3ca3ab9a (patch)
treea0b51a3c2a85280fcd25c3e4e8e4ffc3b3d19773 /bin
parent89a9a866fee33fc0298b68918586d7dba3f2b203 (diff)
downloadFreeBSD-src-75914bbe383daf52ea7fc212276685cc3ca3ab9a.zip
FreeBSD-src-75914bbe383daf52ea7fc212276685cc3ca3ab9a.tar.gz
Fix 'noatime' bug that was unrelated to use of noatime.
The problem is caused when a directory block is compacted. When this occurs, softdep_change_directoryentry_offset() is called to relocate each directory entry and adjust its matching diradd structure, if any, to match the new location of the entry. The bug is that while softdep_change_directoryentry_offset() correctly adjusts the offsets of the diradd structures on the pd_diraddhd[] lists (which are not yet ready to be committed to disk), it fails to adjust the offsets of the diradd structures on the pd_pendinghd list (which are ready to be committed to disk). This causes the dependency structures to be inconsistent with the buf contents. Now, if the compaction has moved a directory entry to the same offset as one of the diradd structures on the pd_pendinghd list *and* a syscall is done that tries to remove this directory entry before this directory block has been written to disk (which would empty pd_pendinghd), a sanity check in newdirrem() will call panic() when it notices that the inode number in the entry that it is to be removed doesn't match the inode number in the diradd structure with that offset of that entry. Reviewed by: Kirk McKusick <mckusick@McKusick.COM> Submitted by: Don Lewis <Don.Lewis@tsc.tdk.com>
Diffstat (limited to 'bin')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud