summaryrefslogtreecommitdiffstats
path: root/bin/sh/mknodes.c
diff options
context:
space:
mode:
authorjilles <jilles@FreeBSD.org>2009-08-28 22:41:25 +0000
committerjilles <jilles@FreeBSD.org>2009-08-28 22:41:25 +0000
commit0bf6e8da4eba6a1fb35ec2e5b2db62e53fec7d32 (patch)
tree7a8084b831c46519ff07655affc5c604f115d66a /bin/sh/mknodes.c
parent9940277b0b89316256a4ba3df75a0b17de8b7157 (diff)
downloadFreeBSD-src-0bf6e8da4eba6a1fb35ec2e5b2db62e53fec7d32.zip
FreeBSD-src-0bf6e8da4eba6a1fb35ec2e5b2db62e53fec7d32.tar.gz
sh: Fix crash with empty functions (f() { }) introduced in r196483
Empty pairs of braces are represented by a NULL node pointer, just like empty lines at the top level. Support for empty pairs of braces may be removed later. They make the code more complex, have inconsistent behaviour (may or may not change $?), are not specified by POSIX and are not allowed by some other shells like bash, dash and ksh93. Reported by: kan
Diffstat (limited to 'bin/sh/mknodes.c')
-rw-r--r--bin/sh/mknodes.c6
1 files changed, 2 insertions, 4 deletions
diff --git a/bin/sh/mknodes.c b/bin/sh/mknodes.c
index 904f9f4..1a177f8 100644
--- a/bin/sh/mknodes.c
+++ b/bin/sh/mknodes.c
@@ -248,11 +248,9 @@ output(char *file)
fputs("\tstruct nodelist *next;\n", hfile);
fputs("\tunion node *n;\n", hfile);
fputs("};\n\n\n", hfile);
- fputs("struct funcdef {\n", hfile);
- fputs("\tunsigned int refcount;\n", hfile);
- fputs("\tunion node n;\n", hfile);
- fputs("};\n\n\n", hfile);
+ fputs("struct funcdef;\n", hfile);
fputs("struct funcdef *copyfunc(union node *);\n", hfile);
+ fputs("union node *getfuncnode(struct funcdef *);\n", hfile);
fputs("void reffunc(struct funcdef *);\n", hfile);
fputs("void unreffunc(struct funcdef *);\n", hfile);
OpenPOWER on IntegriCloud