diff options
| author | avg <avg@FreeBSD.org> | 2017-09-26 09:31:17 +0000 |
|---|---|---|
| committer | avg <avg@FreeBSD.org> | 2017-09-26 09:31:17 +0000 |
| commit | 3b00a62a3635ddfd563366ae6b35d38adbf61dde (patch) | |
| tree | 356a487c611266e2ee2115eeeb23667f2f2e4c69 | |
| parent | 68896d08c13fabea18690d4c5369de8a5e24ba82 (diff) | |
| download | FreeBSD-src-3b00a62a3635ddfd563366ae6b35d38adbf61dde.zip FreeBSD-src-3b00a62a3635ddfd563366ae6b35d38adbf61dde.tar.gz | |
MFC r323480: zfs_get_vfs: reference a requested filesystem instead of vfs_busy-ing it
Sponsored by: Panzura
| -rw-r--r-- | sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c | 16 |
1 files changed, 6 insertions, 10 deletions
diff --git a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c index 29f2411..a60865d 100644 --- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c +++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c @@ -3041,13 +3041,11 @@ zfs_get_vfs(const char *resource) mtx_lock(&mountlist_mtx); TAILQ_FOREACH(vfsp, &mountlist, mnt_list) { if (strcmp(refstr_value(vfsp->vfs_resource), resource) == 0) { - if (vfs_busy(vfsp, MBF_MNTLSTLOCK) != 0) - vfsp = NULL; + vfs_ref(vfsp); break; } } - if (vfsp == NULL) - mtx_unlock(&mountlist_mtx); + mtx_unlock(&mountlist_mtx); return (vfsp); } @@ -3537,7 +3535,9 @@ zfs_unmount_snap(const char *snapname) { vfs_t *vfsp; zfsvfs_t *zfsvfs; +#ifdef illumos int err; +#endif if (strchr(snapname, '@') == NULL) return (0); @@ -3549,23 +3549,19 @@ zfs_unmount_snap(const char *snapname) zfsvfs = vfsp->vfs_data; ASSERT(!dsl_pool_config_held(dmu_objset_pool(zfsvfs->z_os))); - err = vn_vfswlock(vfsp->vfs_vnodecovered); #ifdef illumos + err = vn_vfswlock(vfsp->vfs_vnodecovered); VFS_RELE(vfsp); -#else - vfs_unbusy(vfsp); -#endif if (err != 0) return (SET_ERROR(err)); +#endif /* * Always force the unmount for snapshots. */ - #ifdef illumos (void) dounmount(vfsp, MS_FORCE, kcred); #else - vfs_ref(vfsp); (void) dounmount(vfsp, MS_FORCE, curthread); #endif return (0); |
