summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoravg <avg@FreeBSD.org>2017-09-26 09:32:29 +0000
committeravg <avg@FreeBSD.org>2017-09-26 09:32:29 +0000
commit428d8d21fd8129298c793db172738a2a8dcfe78b (patch)
treee89d78ef19963aac35e0712afc9dbf0c0f485c8b
parentef27058ba5aecdfcb9270b14b07e9b302ccce85a (diff)
downloadFreeBSD-src-428d8d21fd8129298c793db172738a2a8dcfe78b.zip
FreeBSD-src-428d8d21fd8129298c793db172738a2a8dcfe78b.tar.gz
MFC r323480: zfs_get_vfs: reference a requested filesystem instead of vfs_busy-ing it
Sponsored by: Panzura
-rw-r--r--sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c16
1 files changed, 6 insertions, 10 deletions
diff --git a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
index 0e2ba77..6049f26 100644
--- a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
+++ b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_ioctl.c
@@ -3040,13 +3040,11 @@ zfs_get_vfs(const char *resource)
mtx_lock(&mountlist_mtx);
TAILQ_FOREACH(vfsp, &mountlist, mnt_list) {
if (strcmp(refstr_value(vfsp->vfs_resource), resource) == 0) {
- if (vfs_busy(vfsp, MBF_MNTLSTLOCK) != 0)
- vfsp = NULL;
+ vfs_ref(vfsp);
break;
}
}
- if (vfsp == NULL)
- mtx_unlock(&mountlist_mtx);
+ mtx_unlock(&mountlist_mtx);
return (vfsp);
}
@@ -3533,7 +3531,9 @@ zfs_unmount_snap(const char *snapname)
{
vfs_t *vfsp;
zfsvfs_t *zfsvfs;
+#ifdef illumos
int err;
+#endif
if (strchr(snapname, '@') == NULL)
return (0);
@@ -3545,23 +3545,19 @@ zfs_unmount_snap(const char *snapname)
zfsvfs = vfsp->vfs_data;
ASSERT(!dsl_pool_config_held(dmu_objset_pool(zfsvfs->z_os)));
- err = vn_vfswlock(vfsp->vfs_vnodecovered);
#ifdef illumos
+ err = vn_vfswlock(vfsp->vfs_vnodecovered);
VFS_RELE(vfsp);
-#else
- vfs_unbusy(vfsp);
-#endif
if (err != 0)
return (SET_ERROR(err));
+#endif
/*
* Always force the unmount for snapshots.
*/
-
#ifdef illumos
(void) dounmount(vfsp, MS_FORCE, kcred);
#else
- vfs_ref(vfsp);
(void) dounmount(vfsp, MS_FORCE, curthread);
#endif
return (0);
OpenPOWER on IntegriCloud