summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authortuexen <tuexen@FreeBSD.org>2014-05-08 20:47:54 +0000
committertuexen <tuexen@FreeBSD.org>2014-05-08 20:47:54 +0000
commitb6b80cf4953ab00f26977b5a1904a1bad0481073 (patch)
tree93edbd90463f0c9382f9b60ef88d77a51b6c2b7d
parent7e07adf133d6a41806e2ba4f386345297ebec692 (diff)
downloadFreeBSD-src-b6b80cf4953ab00f26977b5a1904a1bad0481073.zip
FreeBSD-src-b6b80cf4953ab00f26977b5a1904a1bad0481073.tar.gz
Use KASSERTs as suggested by glebius@
MFC after: 3 days X-MFC with: 265691
-rw-r--r--sys/netinet/ip_output.c16
1 files changed, 2 insertions, 14 deletions
diff --git a/sys/netinet/ip_output.c b/sys/netinet/ip_output.c
index 1373c10..8039196 100644
--- a/sys/netinet/ip_output.c
+++ b/sys/netinet/ip_output.c
@@ -892,20 +892,8 @@ in_delayed_cksum(struct mbuf *m)
offset -= m->m_len;
m = m->m_next;
}
- if (m == NULL) {
- /* This should not happen. */
- printf("in_delayed_cksum(): checksum outside mbuf chain.\n");
- return;
- }
- if (offset + sizeof(u_short) > m->m_len) {
- /*
- * XXX
- * This should not happen, but if it does, it might make more
- * sense to fix the caller than to add code to split it here.
- */
- printf("in_delayed_cksum(): checksum split between mbufs.\n");
- return;
- }
+ KASSERT(m != NULL, ("in_delayed_cksum: checksum outside mbuf chain."));
+ KASSERT(offset + sizeof(u_short) <= m->m_len, ("in_delayed_cksum: checksum split between mbufs."));
*(u_short *)(m->m_data + offset) = csum;
}
OpenPOWER on IntegriCloud