diff options
| author | delphij <delphij@FreeBSD.org> | 2017-08-02 05:30:41 +0000 |
|---|---|---|
| committer | delphij <delphij@FreeBSD.org> | 2017-08-02 05:30:41 +0000 |
| commit | 6930880dd8f9e0ae46019c3997d84eab3e8655a6 (patch) | |
| tree | 6f54df9975be717a4428a1da5b4765bf38b80255 | |
| parent | 0f9f035b3dea085d48fb3a55e0a2649643158dbe (diff) | |
| download | FreeBSD-src-6930880dd8f9e0ae46019c3997d84eab3e8655a6.zip FreeBSD-src-6930880dd8f9e0ae46019c3997d84eab3e8655a6.tar.gz | |
MFC r320761:
- Use strlcat() instead of strncat().
- Use asprintf() and handle allocation errors.
| -rw-r--r-- | sbin/init/init.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/sbin/init/init.c b/sbin/init/init.c index 25ac2bd..f4206c4 100644 --- a/sbin/init/init.c +++ b/sbin/init/init.c @@ -1271,8 +1271,8 @@ new_session(session_t *sprev, struct ttyent *typ) sp->se_flags |= SE_PRESENT; - sp->se_device = malloc(sizeof(_PATH_DEV) + strlen(typ->ty_name)); - sprintf(sp->se_device, "%s%s", _PATH_DEV, typ->ty_name); + if (asprintf(&sp->se_device, "%s%s", _PATH_DEV, typ->ty_name) < 0) + err(1, "asprintf"); /* * Attempt to open the device, if we get "device not configured" @@ -1315,8 +1315,8 @@ setupargv(session_t *sp, struct ttyent *typ) free(sp->se_getty_argv_space); free(sp->se_getty_argv); } - sp->se_getty = malloc(strlen(typ->ty_getty) + strlen(typ->ty_name) + 2); - sprintf(sp->se_getty, "%s %s", typ->ty_getty, typ->ty_name); + if (asprintf(&sp->se_getty, "%s %s", typ->ty_getty, typ->ty_name) < 0) + err(1, "asprintf"); sp->se_getty_argv_space = strdup(sp->se_getty); sp->se_getty_argv = construct_argv(sp->se_getty_argv_space); if (sp->se_getty_argv == NULL) { @@ -1429,7 +1429,7 @@ start_window_system(session_t *sp) if (sp->se_type) { /* Don't use malloc after fork */ strcpy(term, "TERM="); - strncat(term, sp->se_type, sizeof(term) - 6); + strlcat(term, sp->se_type, sizeof(term)); env[0] = term; env[1] = 0; } @@ -1493,7 +1493,7 @@ start_getty(session_t *sp) if (sp->se_type) { /* Don't use malloc after fork */ strcpy(term, "TERM="); - strncat(term, sp->se_type, sizeof(term) - 6); + strlcat(term, sp->se_type, sizeof(term)); env[0] = term; env[1] = 0; } else |
