summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoremaste <emaste@FreeBSD.org>2016-03-08 00:09:34 +0000
committeremaste <emaste@FreeBSD.org>2016-03-08 00:09:34 +0000
commit59e6727d40bb96c1da8a29c5c49b94e13b4296c4 (patch)
tree8d0efd70a9ffce436681dc5d53404d55c939a7de
parent064eabeacba9d8ebad23759ef5d66b042435247b (diff)
downloadFreeBSD-src-59e6727d40bb96c1da8a29c5c49b94e13b4296c4.zip
FreeBSD-src-59e6727d40bb96c1da8a29c5c49b94e13b4296c4.tar.gz
libc/{i386,amd64}: Do not export .cerror when building WITHOUT_SYMVER
Further to r240152 (i386) and r240178 (amd64), hide the .cerror symbol so that it is not exported if symbol versioning is not in use. Without this change WITHOUT_SYMVER libc contains .text relocations for .cerror, as described in LLVM PR 26813 (http://llvm.org/pr26813). This is a no-op for the regular build as the symbol version script already controls .cerror visibility. PR: 207712 Submitted by: Rafael EspĂ­ndola Reviewed by: jilles, kib Differential Revision: https://reviews.freebsd.org/D5571
-rw-r--r--lib/libc/amd64/sys/cerror.S1
-rw-r--r--lib/libc/i386/sys/cerror.S1
2 files changed, 2 insertions, 0 deletions
diff --git a/lib/libc/amd64/sys/cerror.S b/lib/libc/amd64/sys/cerror.S
index d01cf4a..d28a139 100644
--- a/lib/libc/amd64/sys/cerror.S
+++ b/lib/libc/amd64/sys/cerror.S
@@ -39,6 +39,7 @@ __FBSDID("$FreeBSD$");
#include "SYS.h"
.globl HIDENAME(cerror)
+ .hidden HIDENAME(cerror)
/*
* The __error() function is thread aware. For non-threaded
diff --git a/lib/libc/i386/sys/cerror.S b/lib/libc/i386/sys/cerror.S
index ad3a033..5101e9e 100644
--- a/lib/libc/i386/sys/cerror.S
+++ b/lib/libc/i386/sys/cerror.S
@@ -39,6 +39,7 @@ __FBSDID("$FreeBSD$");
#include "SYS.h"
.globl HIDENAME(cerror)
+ .hidden HIDENAME(cerror)
/*
* The __error() function is thread aware. For non-threaded
OpenPOWER on IntegriCloud