diff options
| author | dougb <dougb@FreeBSD.org> | 2010-04-06 05:20:46 +0000 |
|---|---|---|
| committer | dougb <dougb@FreeBSD.org> | 2010-04-06 05:20:46 +0000 |
| commit | e9fbee49d7ea41f69a621391939d5d7b8b13f82e (patch) | |
| tree | 171cae2e526f97b3669f6e6f8dda9975616870be | |
| parent | 6edfadb92d49ec7231a5dbef34cacfe3da1295d5 (diff) | |
| download | FreeBSD-src-e9fbee49d7ea41f69a621391939d5d7b8b13f82e.zip FreeBSD-src-e9fbee49d7ea41f69a621391939d5d7b8b13f82e.tar.gz | |
In wait_for_pids(), pwait(1) can return when the process exits, but
still exists as a zombie. The 'kill -0' test in this function can
therefore return true even if the process isn't actually running.
This could lead to wait_for_pids() printing an endless string of the
pid number until the zombie finally exits.
Solve this problem by moving the sleep up to after the 'kill -0' test, but
only after we've run through the function once already. In the common case
(only one pid in the list) this will always do the right thing. On the rare
occasion that there is more than one pid in the list this will sleep 1
second per zombie process which will allow that process, and any other
in the list a chance to exit.
While I'm here, local'ize the variables that this function uses.
| -rw-r--r-- | etc/rc.subr | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/etc/rc.subr b/etc/rc.subr index 0c28f2d..18273be 100644 --- a/etc/rc.subr +++ b/etc/rc.subr @@ -355,6 +355,8 @@ _find_processes() # wait_for_pids() { + local _list _prefix _nlist _j + _list="$@" if [ -z "$_list" ]; then return @@ -365,6 +367,7 @@ wait_for_pids() for _j in $_list; do if kill -0 $_j 2>/dev/null; then _nlist="${_nlist}${_nlist:+ }$_j" + [ -n "$_prefix" ] && sleep 1 fi done if [ -z "$_nlist" ]; then @@ -373,7 +376,7 @@ wait_for_pids() _list=$_nlist echo -n ${_prefix:-"Waiting for PIDS: "}$_list _prefix=", " - pwait $_list 2>/dev/null || sleep 2 + pwait $_list 2>/dev/null done if [ -n "$_prefix" ]; then echo "." |
