diff options
author | truckman <truckman@FreeBSD.org> | 2016-05-25 05:20:34 +0000 |
---|---|---|
committer | truckman <truckman@FreeBSD.org> | 2016-05-25 05:20:34 +0000 |
commit | e891aa6cfef5b58a83fd46c7e9b4ffc9b053157e (patch) | |
tree | 5cf3fd5aef73ba59cda5a7f5833aa17866bdc4de | |
parent | 01033af8a17669d80647004092e350d756fef029 (diff) | |
download | FreeBSD-src-e891aa6cfef5b58a83fd46c7e9b4ffc9b053157e.zip FreeBSD-src-e891aa6cfef5b58a83fd46c7e9b4ffc9b053157e.tar.gz |
Fix Coverity CID 1019054 (String not null terminated) in setfacl.
Increase the size of buf[] by one to allow room for a NUL character
at the end.
Reported by: Coverity
CID: 1019054
MFC after: 1 week
-rw-r--r-- | bin/setfacl/file.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/bin/setfacl/file.c b/bin/setfacl/file.c index c44f398..e5e19a2 100644 --- a/bin/setfacl/file.c +++ b/bin/setfacl/file.c @@ -43,7 +43,7 @@ acl_t get_acl_from_file(const char *filename) { FILE *file; - char buf[BUFSIZ]; + char buf[BUFSIZ+1]; if (filename == NULL) err(1, "(null) filename in get_acl_from_file()"); @@ -61,7 +61,7 @@ get_acl_from_file(const char *filename) err(1, "fopen() %s failed", filename); } - fread(buf, sizeof(buf), (size_t)1, file); + fread(buf, sizeof(buf) - 1, (size_t)1, file); if (ferror(file) != 0) { fclose(file); err(1, "error reading from %s", filename); |