diff options
author | delphij <delphij@FreeBSD.org> | 2005-01-27 14:44:39 +0000 |
---|---|---|
committer | delphij <delphij@FreeBSD.org> | 2005-01-27 14:44:39 +0000 |
commit | fa89c5605faa7ae6d16c35fc946e46a24e9d1efe (patch) | |
tree | 800108ee5884bcedcb1f18818809981552758c56 | |
parent | 1f1fe48dc9a77d0ec832c8d740c61402285c96a9 (diff) | |
download | FreeBSD-src-fa89c5605faa7ae6d16c35fc946e46a24e9d1efe.zip FreeBSD-src-fa89c5605faa7ae6d16c35fc946e46a24e9d1efe.tar.gz |
WARNS?=6 cleanup for [gs]et[fp]mac:
- Constify structure members that should not be changed
during process.
- Apply static where needed
- signed/unsigned madness
- Bump WARNS?= levels from 2 to 6
(this is a diff reduction for a subsequent commit against these
Makefile's)
-rw-r--r-- | usr.sbin/getfmac/Makefile | 2 | ||||
-rw-r--r-- | usr.sbin/getfmac/getfmac.c | 2 | ||||
-rw-r--r-- | usr.sbin/getpmac/Makefile | 2 | ||||
-rw-r--r-- | usr.sbin/getpmac/getpmac.c | 2 | ||||
-rw-r--r-- | usr.sbin/setfmac/Makefile | 2 | ||||
-rw-r--r-- | usr.sbin/setfmac/setfmac.c | 6 | ||||
-rw-r--r-- | usr.sbin/setpmac/Makefile | 2 | ||||
-rw-r--r-- | usr.sbin/setpmac/setpmac.c | 4 |
8 files changed, 11 insertions, 11 deletions
diff --git a/usr.sbin/getfmac/Makefile b/usr.sbin/getfmac/Makefile index 4e532e6..ebc2a15 100644 --- a/usr.sbin/getfmac/Makefile +++ b/usr.sbin/getfmac/Makefile @@ -4,6 +4,6 @@ PROG= getfmac MAN= getfmac.8 SRCS= getfmac.c -WARNS?= 2 +WARNS?= 6 .include <bsd.prog.mk> diff --git a/usr.sbin/getfmac/getfmac.c b/usr.sbin/getfmac/getfmac.c index 351f43e..7c03d59 100644 --- a/usr.sbin/getfmac/getfmac.c +++ b/usr.sbin/getfmac/getfmac.c @@ -46,7 +46,7 @@ #define MAXELEMENTS 32 -void +static void usage(void) { diff --git a/usr.sbin/getpmac/Makefile b/usr.sbin/getpmac/Makefile index 962a3e7..b6ff037 100644 --- a/usr.sbin/getpmac/Makefile +++ b/usr.sbin/getpmac/Makefile @@ -4,6 +4,6 @@ PROG= getpmac MAN= getpmac.8 SRCS= getpmac.c -WARNS?= 2 +WARNS?= 6 .include <bsd.prog.mk> diff --git a/usr.sbin/getpmac/getpmac.c b/usr.sbin/getpmac/getpmac.c index ee289e8..6e81558 100644 --- a/usr.sbin/getpmac/getpmac.c +++ b/usr.sbin/getpmac/getpmac.c @@ -46,7 +46,7 @@ #define MAXELEMENTS 32 -void +static void usage(void) { diff --git a/usr.sbin/setfmac/Makefile b/usr.sbin/setfmac/Makefile index bc3c21e..b4e2203 100644 --- a/usr.sbin/setfmac/Makefile +++ b/usr.sbin/setfmac/Makefile @@ -5,6 +5,6 @@ LINKS= ${BINDIR}/setfmac ${BINDIR}/setfsmac MAN= setfmac.8 setfsmac.8 SRCS= setfmac.c -WARNS?= 2 +WARNS?= 6 .include <bsd.prog.mk> diff --git a/usr.sbin/setfmac/setfmac.c b/usr.sbin/setfmac/setfmac.c index d5f5a61..f382cb2 100644 --- a/usr.sbin/setfmac/setfmac.c +++ b/usr.sbin/setfmac/setfmac.c @@ -54,7 +54,7 @@ struct label_spec { regex_t regex; /* compiled regular expression to match */ char *regexstr; /* uncompiled regular expression */ mode_t mode; /* mode to possibly match */ - char *modestr; /* print-worthy ",-?" mode string */ + const char *modestr; /* print-worthy ",-?" mode string */ char *mactext; /* MAC label to apply */ int flags; /* miscellaneous flags */ #define F_DONTLABEL 0x01 @@ -195,13 +195,13 @@ usage(int is_setfmac) exit(1); } -int +static int chomp_line(char **line, size_t *linesize) { char *s; int freeme = 0; - for (s = *line; s - *line < *linesize; s++) { + for (s = *line; (unsigned)(s - *line) < *linesize; s++) { if (!isspace(*s)) break; } diff --git a/usr.sbin/setpmac/Makefile b/usr.sbin/setpmac/Makefile index 08b8b93..ca398ea 100644 --- a/usr.sbin/setpmac/Makefile +++ b/usr.sbin/setpmac/Makefile @@ -4,6 +4,6 @@ PROG= setpmac MAN= setpmac.8 SRCS= setpmac.c -WARNS?= 2 +WARNS?= 6 .include <bsd.prog.mk> diff --git a/usr.sbin/setpmac/setpmac.c b/usr.sbin/setpmac/setpmac.c index 8314a77..bc096bb 100644 --- a/usr.sbin/setpmac/setpmac.c +++ b/usr.sbin/setpmac/setpmac.c @@ -46,7 +46,7 @@ #define MAXELEMENTS 32 -void +static void usage(void) { @@ -57,7 +57,7 @@ usage(void) int main(int argc, char *argv[]) { - char *shell; + const char *shell; mac_t label; int error; |