diff options
| author | alfred <alfred@FreeBSD.org> | 2009-08-24 05:03:30 +0000 |
|---|---|---|
| committer | alfred <alfred@FreeBSD.org> | 2009-08-24 05:03:30 +0000 |
| commit | ec2c313c624d417e5a91c68edc00b7b7b0ed0693 (patch) | |
| tree | 43691d1412c99f66949a6ea7187748a4abc85748 | |
| parent | d30306640e36c93a94bcdb1a09cd35cfbbac2573 (diff) | |
| download | FreeBSD-src-ec2c313c624d417e5a91c68edc00b7b7b0ed0693.zip FreeBSD-src-ec2c313c624d417e5a91c68edc00b7b7b0ed0693.tar.gz | |
Add a reminder comment to optimize bus_dmamap_sync calls.
Submitted by: hps
| -rw-r--r-- | sys/dev/usb/usb_busdma.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/sys/dev/usb/usb_busdma.c b/sys/dev/usb/usb_busdma.c index 3769102..177b94f 100644 --- a/sys/dev/usb/usb_busdma.c +++ b/sys/dev/usb/usb_busdma.c @@ -679,6 +679,12 @@ usb_pc_cpu_invalidate(struct usb_page_cache *pc) /* nothing has been loaded into this page cache! */ return; } + + /* + * TODO: We currently do XXX_POSTREAD and XXX_PREREAD at the + * same time, but in the future we should try to isolate the + * different cases to optimise the code. --HPS + */ bus_dmamap_sync(pc->tag, pc->map, BUS_DMASYNC_POSTREAD); bus_dmamap_sync(pc->tag, pc->map, BUS_DMASYNC_PREREAD); } |
