diff options
| author | mav <mav@FreeBSD.org> | 2013-08-24 09:42:14 +0000 |
|---|---|---|
| committer | mav <mav@FreeBSD.org> | 2013-08-24 09:42:14 +0000 |
| commit | e8031ce26c0c12d1c7b4c0eb69a6887d48355ccf (patch) | |
| tree | 724c9efe931c745ab377f18541d3a299e6100904 | |
| parent | 281a193b5361cf3955f69760d10d8bb1e29651c7 (diff) | |
| download | FreeBSD-src-e8031ce26c0c12d1c7b4c0eb69a6887d48355ccf.zip FreeBSD-src-e8031ce26c0c12d1c7b4c0eb69a6887d48355ccf.tar.gz | |
Add new attribute lunname to report only textual LUN-specific device IDs.
While lunid attribute prefers to report numeric ones, having both may be
useful in some situations.
| -rw-r--r-- | sys/cam/cam_xpt.c | 14 | ||||
| -rw-r--r-- | sys/geom/geom_disk.c | 6 |
2 files changed, 15 insertions, 5 deletions
diff --git a/sys/cam/cam_xpt.c b/sys/cam/cam_xpt.c index 2b94d10..da0b4da 100644 --- a/sys/cam/cam_xpt.c +++ b/sys/cam/cam_xpt.c @@ -1091,7 +1091,8 @@ xpt_getattr(char *buf, size_t len, const char *attr, struct cam_path *path) cdai.buftype = CDAI_TYPE_SERIAL_NUM; else if (!strcmp(attr, "GEOM::physpath")) cdai.buftype = CDAI_TYPE_PHYS_PATH; - else if (!strcmp(attr, "GEOM::lunid")) { + else if (strcmp(attr, "GEOM::lunid") == 0 || + strcmp(attr, "GEOM::lunname") == 0) { cdai.buftype = CDAI_TYPE_SCSI_DEVID; cdai.bufsiz = CAM_SCSI_DEVID_MAXLEN; } else @@ -1108,11 +1109,14 @@ xpt_getattr(char *buf, size_t len, const char *attr, struct cam_path *path) if (cdai.provsiz == 0) goto out; if (cdai.buftype == CDAI_TYPE_SCSI_DEVID) { - idd = scsi_get_devid((struct scsi_vpd_device_id *)cdai.buf, - cdai.provsiz, scsi_devid_is_lun_naa); - if (idd == NULL) + if (strcmp(attr, "GEOM::lunid") == 0) { idd = scsi_get_devid((struct scsi_vpd_device_id *)cdai.buf, - cdai.provsiz, scsi_devid_is_lun_eui64); + cdai.provsiz, scsi_devid_is_lun_naa); + if (idd == NULL) + idd = scsi_get_devid((struct scsi_vpd_device_id *)cdai.buf, + cdai.provsiz, scsi_devid_is_lun_eui64); + } else + idd = NULL; if (idd == NULL) idd = scsi_get_devid((struct scsi_vpd_device_id *)cdai.buf, cdai.provsiz, scsi_devid_is_lun_t10); diff --git a/sys/geom/geom_disk.c b/sys/geom/geom_disk.c index 60cff73..732b35d 100644 --- a/sys/geom/geom_disk.c +++ b/sys/geom/geom_disk.c @@ -460,6 +460,12 @@ g_disk_dumpconf(struct sbuf *sb, const char *indent, struct g_geom *gp, struct g if (dp->d_getattr(bp) == 0) sbuf_printf(sb, "%s<lunid>%s</lunid>\n", indent, buf); + bp->bio_attribute = "GEOM::lunname"; + bp->bio_length = DISK_IDENT_SIZE; + bp->bio_data = buf; + if (dp->d_getattr(bp) == 0) + sbuf_printf(sb, "%s<lunname>%s</lunname>\n", + indent, buf); g_destroy_bio(bp); g_free(buf); } else |
