diff options
author | arybchik <arybchik@FreeBSD.org> | 2017-01-02 09:28:07 +0000 |
---|---|---|
committer | arybchik <arybchik@FreeBSD.org> | 2017-01-02 09:28:07 +0000 |
commit | 972d94d2d312e9f25aa1b545b6165d76a1b343bf (patch) | |
tree | c7044c939e32aa6cc206b8f4e2119e11a735b5b6 | |
parent | 930d721d9f0bc6dedf689d993811d02cb13c7f99 (diff) | |
download | FreeBSD-src-972d94d2d312e9f25aa1b545b6165d76a1b343bf.zip FreeBSD-src-972d94d2d312e9f25aa1b545b6165d76a1b343bf.tar.gz |
MFC r310741
sfxge(4): fix misuse of siena_build_filter in common code
Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
-rw-r--r-- | sys/dev/sfxge/common/efx_filter.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sys/dev/sfxge/common/efx_filter.c b/sys/dev/sfxge/common/efx_filter.c index 4ef0fcc..dd62b59 100644 --- a/sys/dev/sfxge/common/efx_filter.c +++ b/sys/dev/sfxge/common/efx_filter.c @@ -1179,6 +1179,7 @@ siena_filter_restore( efx_oword_t filter; int filter_idx; int state; + uint32_t key; efx_rc_t rc; EFSYS_LOCK(enp->en_eslp, state); @@ -1192,8 +1193,10 @@ siena_filter_restore( continue; spec = &sftp->sft_spec[filter_idx]; - if ((rc = siena_filter_build(&filter, spec)) != 0) + if ((key = siena_filter_build(&filter, spec)) == 0) { + rc = EINVAL; goto fail1; + } if ((rc = siena_filter_push_entry(enp, spec->sfs_type, filter_idx, &filter)) != 0) goto fail2; |