diff options
| author | jhb <jhb@FreeBSD.org> | 2010-08-19 16:40:30 +0000 |
|---|---|---|
| committer | jhb <jhb@FreeBSD.org> | 2010-08-19 16:40:30 +0000 |
| commit | 2f662f7a9c32a8b51811121d5b8e9c807345962b (patch) | |
| tree | a4a02dddf1ebb50f016bf7382a1e89d56fdfe7e5 | |
| parent | 61e0ffd17126aa793382d8f10f2b1f0004ae47c2 (diff) | |
| download | FreeBSD-src-2f662f7a9c32a8b51811121d5b8e9c807345962b.zip FreeBSD-src-2f662f7a9c32a8b51811121d5b8e9c807345962b.tar.gz | |
There isn't really a need to hold the ktrace mutex just to read the value
of p_traceflag that is stored in the kinfo_proc structure. It is still
racey even with the lock and the code will read a consistent snapshot of
the flag without the lock.
| -rw-r--r-- | sys/kern/kern_proc.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/sys/kern/kern_proc.c b/sys/kern/kern_proc.c index beab035..223bf7d 100644 --- a/sys/kern/kern_proc.c +++ b/sys/kern/kern_proc.c @@ -64,10 +64,6 @@ __FBSDID("$FreeBSD$"); #include <sys/jail.h> #include <sys/vnode.h> #include <sys/eventhandler.h> -#ifdef KTRACE -#include <sys/uio.h> -#include <sys/ktrace.h> -#endif #ifdef DDB #include <ddb/ddb.h> @@ -717,9 +713,7 @@ fill_kinfo_proc_only(struct proc *p, struct kinfo_proc *kp) kp->ki_textvp = p->p_textvp; #ifdef KTRACE kp->ki_tracep = p->p_tracevp; - mtx_lock(&ktrace_mtx); kp->ki_traceflag = p->p_traceflag; - mtx_unlock(&ktrace_mtx); #endif kp->ki_fd = p->p_fd; kp->ki_vmspace = p->p_vmspace; |
