diff options
| author | sbruno <sbruno@FreeBSD.org> | 2012-09-23 22:53:39 +0000 |
|---|---|---|
| committer | sbruno <sbruno@FreeBSD.org> | 2012-09-23 22:53:39 +0000 |
| commit | 236cc73ab5f44b7de14d993f61821f86700fb6f6 (patch) | |
| tree | 6a5d7902e8fb0f3e8c5f07d3831bdd5fe8fed6ef | |
| parent | 212634d921b6016d77a964b0299d6df7a93aacc1 (diff) | |
| download | FreeBSD-src-236cc73ab5f44b7de14d993f61821f86700fb6f6.zip FreeBSD-src-236cc73ab5f44b7de14d993f61821f86700fb6f6.tar.gz | |
This patch fixes a nit in the em, lem, and igb driver statistics. Increment
adapter->dropped_pkts instead of if_ierrors because if_ierrors is
overwritten by hw stats collection.
Submitted by: Andrew Boyer <aboyer@averesystems.com>
Reviewed by: Jack F Vogel <jfv@freebsd.org>
MFC after: 2 weeks
| -rw-r--r-- | sys/dev/e1000/if_em.c | 2 | ||||
| -rw-r--r-- | sys/dev/e1000/if_igb.c | 2 | ||||
| -rw-r--r-- | sys/dev/e1000/if_lem.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/sys/dev/e1000/if_em.c b/sys/dev/e1000/if_em.c index 60e6708..63f399f 100644 --- a/sys/dev/e1000/if_em.c +++ b/sys/dev/e1000/if_em.c @@ -4436,7 +4436,7 @@ em_rxeof(struct rx_ring *rxr, int count, int *done) if ((cur->errors & E1000_RXD_ERR_FRAME_ERR_MASK) || (rxr->discard == TRUE)) { - ifp->if_ierrors++; + adapter->dropped_pkts++; ++rxr->rx_discarded; if (!eop) /* Catch subsequent segs */ rxr->discard = TRUE; diff --git a/sys/dev/e1000/if_igb.c b/sys/dev/e1000/if_igb.c index 085ebc4..cd91ad4 100644 --- a/sys/dev/e1000/if_igb.c +++ b/sys/dev/e1000/if_igb.c @@ -4759,7 +4759,7 @@ igb_rxeof(struct igb_queue *que, int count, int *done) /* Make sure all segments of a bad packet are discarded */ if (((staterr & E1000_RXDEXT_ERR_FRAME_ERR_MASK) != 0) || (rxr->discard)) { - ifp->if_ierrors++; + adapter->dropped_pkts++; ++rxr->rx_discarded; if (!eop) /* Catch subsequent segs */ rxr->discard = TRUE; diff --git a/sys/dev/e1000/if_lem.c b/sys/dev/e1000/if_lem.c index 882bd3c..8c467f1 100644 --- a/sys/dev/e1000/if_lem.c +++ b/sys/dev/e1000/if_lem.c @@ -3562,7 +3562,7 @@ skip: adapter->lmp = NULL; } } else { - ifp->if_ierrors++; + adapter->dropped_pkts++; discard: /* Reuse loaded DMA map and just update mbuf chain */ mp = adapter->rx_buffer_area[i].m_head; |
