summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorcperciva <cperciva@FreeBSD.org>2004-02-22 09:55:48 +0000
committercperciva <cperciva@FreeBSD.org>2004-02-22 09:55:48 +0000
commit11443ed5cb7895dd184ec0cd5163eb79b305ac15 (patch)
treeaf86b4d32e45b46ff195ee29fd815ba245240fb5
parente4a1f86f9c21cb53a38b99482b318ee58e71b3bd (diff)
downloadFreeBSD-src-11443ed5cb7895dd184ec0cd5163eb79b305ac15.zip
FreeBSD-src-11443ed5cb7895dd184ec0cd5163eb79b305ac15.tar.gz
Don't free k_cfg until we're finished using it -- reverse the order of
two free commands. Reported by: "Ted Unangst" <tedu@coverity.com> Approved by: rwatson (mentor), scottl
-rw-r--r--sys/dev/raidframe/rf_freebsdkintf.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/raidframe/rf_freebsdkintf.c b/sys/dev/raidframe/rf_freebsdkintf.c
index 585fad7..13f5abb 100644
--- a/sys/dev/raidframe/rf_freebsdkintf.c
+++ b/sys/dev/raidframe/rf_freebsdkintf.c
@@ -515,9 +515,9 @@ raidctlioctl(dev_t dev, u_long cmd, caddr_t data, int flags, struct thread *td)
(caddr_t) specific_buf,
k_cfg->layoutSpecificSize);
if (retcode) {
- RF_Free(k_cfg, sizeof(RF_Config_t));
RF_Free(specific_buf,
k_cfg->layoutSpecificSize);
+ RF_Free(k_cfg, sizeof(RF_Config_t));
rf_printf(2, "raidctlioctl: retcode=%d "
"copyin.2\n", retcode);
return (retcode);
OpenPOWER on IntegriCloud