summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbschmidt <bschmidt@FreeBSD.org>2010-12-31 09:50:15 +0000
committerbschmidt <bschmidt@FreeBSD.org>2010-12-31 09:50:15 +0000
commit8d62f2942224e7f0d7e73fc061859699615f1398 (patch)
tree51805c35e97c19dd5da63d9df52a0338d5cc96ff
parentcd4bb64d19f4a69aad023c55a542106ccdda628e (diff)
downloadFreeBSD-src-8d62f2942224e7f0d7e73fc061859699615f1398.zip
FreeBSD-src-8d62f2942224e7f0d7e73fc061859699615f1398.tar.gz
The mwl's HAL manages an array of MWL_MBSS_MAX VAPs where the first 8 are
supposed to be APs and the later 24 are pre-configured as STAs. A wrong condition during initialization is responsible for not configuring the last 8 array members. This is results in being able to create more than 8, possible uninitialized, AP-VAPs. PR: kern/153549 Submitted by: Erik Fonnesbeck <efonnes at gmail.com> MFC after: 2 weeks
-rw-r--r--sys/dev/mwl/mwlhal.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/mwl/mwlhal.c b/sys/dev/mwl/mwlhal.c
index 3f953ac..ffc956f 100644
--- a/sys/dev/mwl/mwlhal.c
+++ b/sys/dev/mwl/mwlhal.c
@@ -279,7 +279,7 @@ mwl_hal_attach(device_t dev, uint16_t devid,
hvap->vap_type = MWL_HAL_STA;
hvap->bss_type = htole16(WL_MAC_TYPE_PRIMARY_CLIENT);
hvap->macid = i;
- for (i++; i < MWL_MBSS_STA_MAX; i++) {
+ for (i++; i < MWL_MBSS_MAX; i++) {
hvap = &mh->mh_vaps[i];
hvap->vap_type = MWL_HAL_STA;
hvap->bss_type = htole16(WL_MAC_TYPE_SECONDARY_CLIENT);
OpenPOWER on IntegriCloud