diff options
| author | marius <marius@FreeBSD.org> | 2012-07-19 14:43:46 +0000 |
|---|---|---|
| committer | marius <marius@FreeBSD.org> | 2012-07-19 14:43:46 +0000 |
| commit | 4594375cbb5c1e8805aa630c4f87e0ca159eccdb (patch) | |
| tree | e4657e4855e24a69ef0d1669858e6bc2df114957 | |
| parent | 900c50d55cf4bbde47dc16b74efebaded79d411f (diff) | |
| download | FreeBSD-src-4594375cbb5c1e8805aa630c4f87e0ca159eccdb.zip FreeBSD-src-4594375cbb5c1e8805aa630c4f87e0ca159eccdb.tar.gz | |
Revert the use of BUS_DMA_ALLOCNOW when creating the DMA tag for user
data introduced in r236061. Using that flag doesn't make that much
sense on this case as the DMA maps using it are also created during
sym_pci_attach(). Moreover, due to the maxsegsz parameter used, doing
so may exhaust the bounce pages pool on architectures requiring
bounce pages. [1]
While at it, use a slightly more appropriate maxsegsz parameter.
PR: 169526
Submitted by: Mike Watters [1]
MFC after: 3 days
| -rw-r--r-- | sys/dev/sym/sym_hipd.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/dev/sym/sym_hipd.c b/sys/dev/sym/sym_hipd.c index 8ac59b9..3c8be40 100644 --- a/sys/dev/sym/sym_hipd.c +++ b/sys/dev/sym/sym_hipd.c @@ -8537,8 +8537,8 @@ sym_pci_attach(device_t dev) */ if (bus_dma_tag_create(np->bus_dmat, 1, SYM_CONF_DMA_BOUNDARY, BUS_SPACE_MAXADDR_32BIT, BUS_SPACE_MAXADDR, NULL, NULL, - BUS_SPACE_MAXSIZE, SYM_CONF_MAX_SG, SYM_CONF_DMA_BOUNDARY, - BUS_DMA_ALLOCNOW, busdma_lock_mutex, &np->mtx, &np->data_dmat)) { + BUS_SPACE_MAXSIZE_32BIT, SYM_CONF_MAX_SG, SYM_CONF_DMA_BOUNDARY, + 0, busdma_lock_mutex, &np->mtx, &np->data_dmat)) { device_printf(dev, "failed to create DMA tag.\n"); goto attach_failed; } |
