diff options
| author | alfred <alfred@FreeBSD.org> | 2002-10-14 21:15:04 +0000 |
|---|---|---|
| committer | alfred <alfred@FreeBSD.org> | 2002-10-14 21:15:04 +0000 |
| commit | c1ef60cbb3f91f6f45ba5f2bc341ace538f70674 (patch) | |
| tree | cf15c1412dbe04ca5ffec1cc3b8113d4e13bce66 | |
| parent | ab086bb517472d22f8c9b8ac4676add1ebb253e5 (diff) | |
| download | FreeBSD-src-c1ef60cbb3f91f6f45ba5f2bc341ace538f70674.zip FreeBSD-src-c1ef60cbb3f91f6f45ba5f2bc341ace538f70674.tar.gz | |
Remove a KASSERT I added in 1.73 to catch uninitialized pipes.
It must be removed because it is done without the pipe being locked
via pipelock() and therefore is vulnerable to races with pipespace()
erroneously triggering it by temporarily zero'ing out the structure
backing the pipe.
It looks as if this assertion is not needed because all manipulation
of the data changed by pipespace() _is_ protected by pipelock().
Reported by: kris, mckusick
| -rw-r--r-- | sys/kern/sys_pipe.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/sys/kern/sys_pipe.c b/sys/kern/sys_pipe.c index 0d98434..d09f31f 100644 --- a/sys/kern/sys_pipe.c +++ b/sys/kern/sys_pipe.c @@ -927,8 +927,6 @@ pipe_write(fp, uio, active_cred, flags, td) return(error); } - KASSERT(wpipe->pipe_buffer.buffer != NULL, ("pipe buffer gone")); - orig_resid = uio->uio_resid; while (uio->uio_resid) { |
