diff options
author | marcel <marcel@FreeBSD.org> | 2008-10-25 17:21:46 +0000 |
---|---|---|
committer | marcel <marcel@FreeBSD.org> | 2008-10-25 17:21:46 +0000 |
commit | 8fb9b724ff720705e8eeeedd65f997aa95f53cdb (patch) | |
tree | 4af0fdefaf7ddc2656aa684ad4d6a341b7eca2fa | |
parent | eca1f4b10732c3b9c6ecd67e589c654830555ef7 (diff) | |
download | FreeBSD-src-8fb9b724ff720705e8eeeedd65f997aa95f53cdb.zip FreeBSD-src-8fb9b724ff720705e8eeeedd65f997aa95f53cdb.tar.gz |
Invalid BSD disklabels have been created by sysinstall and
are possibly still being created. The d_secperunit field
contains the number of sectors of the disk and not of the
slice/partition to which the disklabel applies.
Rather than reject the disklabel, we now silently adjust
the field. Existing code, like bslabel(8), does not seem
to check the label that extensively and seems to adjust
fields as a side-effect as well.
In other words, it's not that important apparently, so
gpart should not be too strict about it.
Reported by: nyan@
Reported by: Andriy Gapon <avg@icyb.net.ua>
-rw-r--r-- | sys/geom/part/g_part_bsd.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/sys/geom/part/g_part_bsd.c b/sys/geom/part/g_part_bsd.c index f7213e3..e87c5a3 100644 --- a/sys/geom/part/g_part_bsd.c +++ b/sys/geom/part/g_part_bsd.c @@ -341,8 +341,13 @@ g_part_bsd_read(struct g_part_table *basetable, struct g_consumer *cp) printf("GEOM: %s: geometry does not match label.\n", pp->name); chs = le32dec(buf + 60); - if (chs < 1 || chs > msize) + if (chs < 1) goto invalid_label; + /* Fix-up a sysinstall bug. */ + if (chs > msize) { + chs = msize; + le32enc(buf + 60, msize); + } if (chs != msize) printf("GEOM: %s: media size does not match label.\n", pp->name); |