diff options
author | ngie <ngie@FreeBSD.org> | 2015-05-13 12:13:18 +0000 |
---|---|---|
committer | ngie <ngie@FreeBSD.org> | 2015-05-13 12:13:18 +0000 |
commit | 855766662788b6a9f5db240b8d8252ffd494fb00 (patch) | |
tree | 67a331966e7e4fa41eb31a7392c70998cf1c46b7 | |
parent | 3a757c0c1f3f1d07c1bcfba87100164c348efa06 (diff) | |
download | FreeBSD-src-855766662788b6a9f5db240b8d8252ffd494fb00.zip FreeBSD-src-855766662788b6a9f5db240b8d8252ffd494fb00.tar.gz |
MFC r282211,r282244:
r282211:
ATF_REQUIRE_KERNEL_MODULE: use atf_skip, not ATF_REQUIRE_MSG so the testcase
no longer bombs out
PLAIN_REQUIRE_KERNEL_MODULE: use printf + _exit, no err so the testcase no
longer bombs out if it prints to stderr
r282244:
Fix typo. It should have been atf_tc_skip, not atf_skip
Reported by: many, Jenkins
Pointyhat to: ngie
-rw-r--r-- | tests/freebsd_test_suite/macros.h | 17 |
1 files changed, 10 insertions, 7 deletions
diff --git a/tests/freebsd_test_suite/macros.h b/tests/freebsd_test_suite/macros.h index 755a994..8d95f05 100644 --- a/tests/freebsd_test_suite/macros.h +++ b/tests/freebsd_test_suite/macros.h @@ -32,21 +32,24 @@ #include <sys/param.h> #include <sys/module.h> #include <string.h> -#include <err.h> #include <errno.h> +#include <stdio.h> +#include <unistd.h> #include <atf-c.h> #define ATF_REQUIRE_KERNEL_MODULE(_mod_name) do { \ - ATF_REQUIRE_MSG(modfind(_mod_name) != -1, \ - "module %s could not be resolved: %s", \ - _mod_name, strerror(errno)); \ + if (modfind(_mod_name) == -1) { \ + atf_tc_skip("module %s could not be resolved: %s", \ + _mod_name, strerror(errno)); \ + } \ } while(0) -#define PLAIN_REQUIRE_KERNEL_MODULE(_mod_name, _exit_code) do { \ +#define PLAIN_REQUIRE_KERNEL_MODULE(_mod_name, _exit_code) do { \ if (modfind(_mod_name) == -1) { \ - err(_exit_code, "module %s could not be resolved", \ - _mod_name); \ + printf("module %s could not be resolved: %s\n", \ + _mod_name, strerror(errno)); \ + _exit(_exit_code); \ } \ } while(0) |