Zero struct sockaddr_??s before filling them in.

Suggested by: Theo de Raadt <deraadt@cvs.openbsd.org>

2 files changed, 6 insertions, 2 deletions

diff --git a/usr.sbin/ppp/server.c b/usr.sbin/ppp/server.c
index d55dbb4..8c15b15 100644
--- a/usr.sbin/ppp/server.c
+++ b/usr.sbin/ppp/server.c
@@ -1,5 +1,5 @@
 /*
- * $Id: server.c,v 1.11 1997/11/22 03:37:45 brian Exp $
+ * $Id: server.c,v 1.12 1997/12/03 10:23:53 brian Exp $
  */
 
 #include <sys/param.h>
@@ -46,6 +46,7 @@ ServerLocalOpen(const char *name, mode_t mask)
     return 1;
   }
 
+  memset(&ifsun, '\0', sizeof ifsun);
   ifsun.sun_len = strlen(name);
   if (ifsun.sun_len > sizeof ifsun.sun_path - 1) {
     LogPrintf(LogERROR, "Local: %s: Path too long\n", name);
@@ -108,6 +109,7 @@ ServerTcpOpen(int port)
     LogPrintf(LogERROR, "Tcp: socket: %s\n", strerror(errno));
     return 7;
   }
+  memset(&ifsin, '\0', sizeof ifsin);
   ifsin.sin_family = AF_INET;
   ifsin.sin_addr.s_addr = INADDR_ANY;
   ifsin.sin_port = htons(port);
diff --git a/usr.sbin/pppctl/pppctl.c b/usr.sbin/pppctl/pppctl.c
index 6e72950..4528e2d 100644
--- a/usr.sbin/pppctl/pppctl.c
+++ b/usr.sbin/pppctl/pppctl.c
@@ -1,5 +1,5 @@
 /*
- * $Id: pppctl.c,v 1.11 1997/12/17 00:26:58 brian Exp $
+ * $Id: pppctl.c,v 1.12 1997/12/18 00:29:56 brian Exp $
  */
 
 #include <sys/types.h>
@@ -210,6 +210,7 @@ main(int argc, char **argv)
         sock = (struct sockaddr *)&ifsun;
         socksz = sizeof ifsun;
 
+        memset(&ifsun, '\0', sizeof ifsun);
         ifsun.sun_len = strlen(argv[arg]);
         if (ifsun.sun_len > sizeof ifsun.sun_path - 1) {
             fprintf(stderr, "%s: Path too long\n", argv[arg]);
@@ -239,6 +240,7 @@ main(int argc, char **argv)
         socksz = sizeof ifsin;
         hlen = strlen(host);
 
+        memset(&ifsin, '\0', sizeof ifsin);
         if (strspn(host, "0123456789.") == hlen) {
             if (!inet_aton(host, &ifsin.sin_addr)) {
                 fprintf(stderr, "Cannot translate %s\n", host);