summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordillon <dillon@FreeBSD.org>1998-12-13 03:44:19 +0000
committerdillon <dillon@FreeBSD.org>1998-12-13 03:44:19 +0000
commiteb1a8914cebef88c6fc3a09a3232ee546d8e7d0f (patch)
tree8f3f572cb8bbb0a222e60aa67afeace97a5e9b3d
parent762deff9e18b9694dd8707b53ced7afb15885668 (diff)
downloadFreeBSD-src-eb1a8914cebef88c6fc3a09a3232ee546d8e7d0f.zip
FreeBSD-src-eb1a8914cebef88c6fc3a09a3232ee546d8e7d0f.tar.gz
PR: bin/8680
Minor adjustments to rwall.c. Increased the size of a couple of char arrays and replaced a potentially dangeerous strcpy/strcat with snprintf().
-rw-r--r--usr.bin/rwall/rwall.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/usr.bin/rwall/rwall.c b/usr.bin/rwall/rwall.c
index 1c5d084..a39e478 100644
--- a/usr.bin/rwall/rwall.c
+++ b/usr.bin/rwall/rwall.c
@@ -43,7 +43,7 @@ static const char copyright[] =
static char sccsid[] = "from: @(#)wall.c 5.14 (Berkeley) 3/2/91";
#endif
static const char rcsid[] =
- "$Id: rwall.c,v 1.5 1997/02/22 19:56:55 peter Exp $";
+ "$Id: rwall.c,v 1.6 1997/08/08 12:18:16 charnier Exp $";
#endif /* not lint */
/*
@@ -134,10 +134,9 @@ makemsg(fname)
time_t now, time();
FILE *fp;
int fd;
- char *whom, hostname[MAXHOSTNAMELEN], lbuf[100], tmpname[15];
+ char *whom, hostname[MAXHOSTNAMELEN], lbuf[256], tmpname[64];
- (void)strcpy(tmpname, _PATH_TMP);
- (void)strcat(tmpname, "wall.XXXXXX");
+ snprintf(tmpname, sizeof(tmpname), "%s/wall.XXXXXX", _PATH_TMP);
if (!(fd = mkstemp(tmpname)) || !(fp = fdopen(fd, "r+")))
errx(1, "can't open temporary file");
(void)unlink(tmpname);
OpenPOWER on IntegriCloud