diff options
author | mav <mav@FreeBSD.org> | 2014-12-05 07:25:02 +0000 |
---|---|---|
committer | mav <mav@FreeBSD.org> | 2014-12-05 07:25:02 +0000 |
commit | c2a2522fc4772c4d0b27b8b65826fd0fc2f2431a (patch) | |
tree | 07e6aeb57dda43720ef4d314e7527a4ed9ed5ae4 | |
parent | 0d78a1c549aca0c9e0ee3f559772568404b3f985 (diff) | |
download | FreeBSD-src-c2a2522fc4772c4d0b27b8b65826fd0fc2f2431a.zip FreeBSD-src-c2a2522fc4772c4d0b27b8b65826fd0fc2f2431a.tar.gz |
MFC r274805:
Make cfiscsi_offline() synchronous, waiting for connections termination
before return. This should make ctld restart more clean and predictable.
-rw-r--r-- | sys/cam/ctl/ctl_frontend_iscsi.c | 10 | ||||
-rw-r--r-- | sys/cam/ctl/ctl_frontend_iscsi.h | 1 |
2 files changed, 11 insertions, 0 deletions
diff --git a/sys/cam/ctl/ctl_frontend_iscsi.c b/sys/cam/ctl/ctl_frontend_iscsi.c index 6308825..e62013c 100644 --- a/sys/cam/ctl/ctl_frontend_iscsi.c +++ b/sys/cam/ctl/ctl_frontend_iscsi.c @@ -1282,6 +1282,7 @@ cfiscsi_session_delete(struct cfiscsi_session *cs) mtx_lock(&softc->lock); TAILQ_REMOVE(&softc->sessions, cs, cs_next); + cv_signal(&softc->sessions_cv); mtx_unlock(&softc->lock); free(cs, M_CFISCSI); @@ -1298,6 +1299,7 @@ cfiscsi_init(void) bzero(softc, sizeof(*softc)); mtx_init(&softc->lock, "cfiscsi", NULL, MTX_DEF); + cv_init(&softc->sessions_cv, "cfiscsi_sessions"); #ifdef ICL_KERNEL_PROXY cv_init(&softc->accept_cv, "cfiscsi_accept"); #endif @@ -1382,6 +1384,14 @@ cfiscsi_offline(void *arg) if (cs->cs_target == ct) cfiscsi_session_terminate(cs); } + do { + TAILQ_FOREACH(cs, &softc->sessions, cs_next) { + if (cs->cs_target == ct) + break; + } + if (cs != NULL) + cv_wait(&softc->sessions_cv, &softc->lock); + } while (cs != NULL && ct->ct_online == 0); mtx_unlock(&softc->lock); if (online > 0) return; diff --git a/sys/cam/ctl/ctl_frontend_iscsi.h b/sys/cam/ctl/ctl_frontend_iscsi.h index 1efe245..336b69d 100644 --- a/sys/cam/ctl/ctl_frontend_iscsi.h +++ b/sys/cam/ctl/ctl_frontend_iscsi.h @@ -115,6 +115,7 @@ struct cfiscsi_softc { unsigned int last_session_id; TAILQ_HEAD(, cfiscsi_target) targets; TAILQ_HEAD(, cfiscsi_session) sessions; + struct cv sessions_cv; #ifdef ICL_KERNEL_PROXY struct icl_listen *listener; struct cv accept_cv; |