summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorphk <phk@FreeBSD.org>2003-01-28 22:44:12 +0000
committerphk <phk@FreeBSD.org>2003-01-28 22:44:12 +0000
commit88b86d19fbf893333c3a2db046d5cb8d0b10bdea (patch)
treeec520e5d0d2d9d114d073b7ffcde4e7ad17649bd
parent3f245d6325bc967e32ea631b54fb87569ded160b (diff)
downloadFreeBSD-src-88b86d19fbf893333c3a2db046d5cb8d0b10bdea.zip
FreeBSD-src-88b86d19fbf893333c3a2db046d5cb8d0b10bdea.tar.gz
Check bounds for index before dereferencing memory past end of array.
Found by: FlexeLint
-rw-r--r--sys/netinet/ip_divert.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/netinet/ip_divert.c b/sys/netinet/ip_divert.c
index f9bad2c..bd8ea4d 100644
--- a/sys/netinet/ip_divert.c
+++ b/sys/netinet/ip_divert.c
@@ -284,7 +284,7 @@ div_output(struct socket *so, struct mbuf *m,
* The name is user supplied data so don't trust its size
* or that it is zero terminated.
*/
- for (i = 0; sin->sin_zero[i] && i < sizeof(sin->sin_zero); i++)
+ for (i = 0; i < sizeof(sin->sin_zero) && sin->sin_zero[i]; i++)
;
if ( i > 0 && i < sizeof(sin->sin_zero))
m->m_pkthdr.rcvif = ifunit(sin->sin_zero);
OpenPOWER on IntegriCloud