summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorthompsa <thompsa@FreeBSD.org>2009-11-08 20:44:55 +0000
committerthompsa <thompsa@FreeBSD.org>2009-11-08 20:44:55 +0000
commit410f2a9fd7c27f9feea4855407b8a73cc612993d (patch)
tree7004b3d6bd6edccfac8084c177a35f01572e4a36
parentaded7665d83d8027dd037eca5ab97e468e90f785 (diff)
downloadFreeBSD-src-410f2a9fd7c27f9feea4855407b8a73cc612993d.zip
FreeBSD-src-410f2a9fd7c27f9feea4855407b8a73cc612993d.tar.gz
ehci_init() will do reset and set the usbrev flag. Fix problem where
ehci_reset() was called before ehci_init(). PR: usb/140242 Submitted by: Sebastian Huber
-rw-r--r--sys/dev/usb/controller/ehci_ixp4xx.c3
-rw-r--r--sys/dev/usb/controller/ehci_mbus.c2
-rw-r--r--sys/dev/usb/controller/ehci_pci.c4
3 files changed, 1 insertions, 8 deletions
diff --git a/sys/dev/usb/controller/ehci_ixp4xx.c b/sys/dev/usb/controller/ehci_ixp4xx.c
index 9f86614..3a2b6e4 100644
--- a/sys/dev/usb/controller/ehci_ixp4xx.c
+++ b/sys/dev/usb/controller/ehci_ixp4xx.c
@@ -157,8 +157,6 @@ ehci_ixp_attach(device_t self)
return (ENOMEM);
}
- sc->sc_bus.usbrev = USB_REV_2_0;
-
/* NB: hints fix the memory location and irq */
rid = 0;
@@ -230,7 +228,6 @@ ehci_ixp_attach(device_t self)
| EHCI_SCFLG_BIGEMMIO
| EHCI_SCFLG_NORESTERM
;
- (void) ehci_reset(sc);
err = ehci_init(sc);
if (!err) {
diff --git a/sys/dev/usb/controller/ehci_mbus.c b/sys/dev/usb/controller/ehci_mbus.c
index d3c0f4c..368e3e5 100644
--- a/sys/dev/usb/controller/ehci_mbus.c
+++ b/sys/dev/usb/controller/ehci_mbus.c
@@ -166,8 +166,6 @@ ehci_mbus_attach(device_t self)
return (ENOMEM);
}
- sc->sc_bus.usbrev = USB_REV_2_0;
-
rid = 0;
sc->sc_io_res = bus_alloc_resource_any(self, SYS_RES_MEMORY, &rid, RF_ACTIVE);
if (!sc->sc_io_res) {
diff --git a/sys/dev/usb/controller/ehci_pci.c b/sys/dev/usb/controller/ehci_pci.c
index fc2035b..d1440c1 100644
--- a/sys/dev/usb/controller/ehci_pci.c
+++ b/sys/dev/usb/controller/ehci_pci.c
@@ -318,13 +318,11 @@ ehci_pci_attach(device_t self)
device_printf(self, "pre-2.0 USB revision (ignored)\n");
/* fallthrough */
case PCI_USB_REV_2_0:
- sc->sc_bus.usbrev = USB_REV_2_0;
break;
default:
/* Quirk for Parallels Desktop 4.0 */
device_printf(self, "USB revision is unknown. Assuming v2.0.\n");
- sc->sc_bus.usbrev = USB_REV_2_0;
- break;
+ break;
}
rid = PCI_CBMEM;
OpenPOWER on IntegriCloud